Selection occurrences are not highlighted at the vertical scroll bar

Environment

Operating System: Ubuntu 14.04
JDK version: /usr/lib/jvm/java-8-openjdk-amd64
Visual Studio Code version: VS Code 1.13.1
Java extension version:

Steps To Reproduce

Open VS Code.
Open Java file.
Selected occurrences are highlighted in the editor and are highlighted the right vertical scroll bar.
Open ANY other file.
Return to ANY Java file.
Selected occurrences are highlighted in the editor, but they ARE NOT highlighted the right vertical scroll bar.

IMPORTANT: if to disable "Java support for Java by RedHat" package, then 6th step is not reproduced (everything works fine).

Current Result

Selection occurrences are not highlighted at the scroll bar.

Expected Result

Selection occurrences are highlighted at the scroll bar.

@aeschli

@aeschli is JLS supposed to provide highlights for the scroll bar too?

Ah, actually I was thinking about the minimap. For me highlighted java code is also highlighted in scroll bar. Even after opening non-java files. But I'm on a Mac, so maybe it's a problem on Linux?

Right, I mean just small grey dashes in the scroll bar.
Anyway, disabling the package make the deal for me. Enabling: and the issue comes back.

The minimap doesn't show any selections or highlights. The overview rule (under the scrollbar does).

Can you attach the file where you see the problem?

@aeschli

@aeschli, I nothing said about minimap, only about scroll bar, here is some confusion. I should have attached the image, my fault. I will attach demo in an hour. Thank you!

@aeschli

@aeschli, @fbricon, I added demo images into description. Thank you for your attention!

Ok I managed to reproduce something similar on macOS.

package foo.bar;

public class Bar {

    public static void main(String[] args) {
        new Bar()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString()
        .toString();
    }
}

1st highlight:

[Trace - 9:33:36 AM] Sending request 'textDocument/documentHighlight - (275)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fbricon/Dev/souk/projects/p11/src/main/java/foo/bar/Bar.java"
    },
    "position": {
        "line": 6,
        "character": 14
    }
}

[Trace - 9:33:36 AM] Received response 'textDocument/documentHighlight - (275)' in 2ms.
Result: [
    {
        "range": {
            "start": {
                "line": 6,
                "character": 9
            },
            "end": {
                "line": 6,
                "character": 17
            }
        },
        "kind": 3
    }
]

2nd highlight:

[Trace - 9:35:14 AM] Sending request 'textDocument/documentHighlight - (278)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fbricon/Dev/souk/projects/p11/src/main/java/foo/bar/Bar.java"
    },
    "position": {
        "line": 7,
        "character": 15
    }
}

[Trace - 9:35:14 AM] Received response 'textDocument/documentHighlight - (278)' in 3ms.
Result: [
    {
        "range": {
            "start": {
                "line": 7,
                "character": 9
            },
            "end": {
                "line": 7,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 8,
                "character": 9
            },
            "end": {
                "line": 8,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 9,
                "character": 9
            },
            "end": {
                "line": 9,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 10,
                "character": 9
            },
            "end": {
                "line": 10,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 11,
                "character": 9
            },
            "end": {
                "line": 11,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 12,
                "character": 9
            },
            "end": {
                "line": 12,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 13,
                "character": 9
            },
            "end": {
                "line": 13,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 14,
                "character": 9
            },
            "end": {
                "line": 14,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 15,
                "character": 9
            },
            "end": {
                "line": 15,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 16,
                "character": 9
            },
            "end": {
                "line": 16,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 17,
                "character": 9
            },
            "end": {
                "line": 17,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 18,
                "character": 9
            },
            "end": {
                "line": 18,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 19,
                "character": 9
            },
            "end": {
                "line": 19,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 20,
                "character": 9
            },
            "end": {
                "line": 20,
                "character": 17
            }
        },
        "kind": 3
    },
    {
        "range": {
            "start": {
                "line": 21,
                "character": 9
            },
            "end": {
                "line": 21,
                "character": 17
            }
        },
        "kind": 3
    }
]

So this looks like a server side issue.

Seems like you reproduced yet another bug, because in my case all highlights in the editor are OK, but on the scrollbar are NOT ok. Still, it looks like in some way related.

@fadeevab

@fadeevab please attach the code of your java class and the relevant message logs

Code:

public class Bar {

    public static void main(String[] args) {
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
    }
}

Double click to "toString" at the 8th line.

[Trace - 5:22:16 PM] Sending request 'textDocument/documentHighlight - (260)'.
Params: {
    "textDocument": {
        "uri": "file:///home/user/foo.java"
    },
    "position": {
        "line": 6,
        "character": 17
    }
}


[Trace - 5:22:16 PM] Received response 'textDocument/documentHighlight - (260)' in 3ms.
Result: []

this is the textDocument/codeAction event. You're looking for textDocument/documentHighlight

Fixed, but it's just the same

in your case it may be caused by your file named foo.java and your class named Bar. The server might be confused by that discrepancy (I'm not sure)

In my case, the highlighting bug can be reproduced in Eclipse. That's comforting. Or not.

I opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=518397

public class foo {

    public static void main(String[] args) {
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
        this.toString();
    }
}

Reload.
Open foo.java.
Logs from the beginning:

[Trace - 5:31:33 PM] Sending request 'initialize - (0)'.
Params: {
    "processId": 18137,
    "rootPath": null,
    "rootUri": null,
    "capabilities": {
        "workspace": {
            "applyEdit": true,
            "workspaceEdit": {
                "documentChanges": true
            },
            "didChangeConfiguration": {
                "dynamicRegistration": false
            },
            "didChangeWatchedFiles": {
                "dynamicRegistration": true
            },
            "symbol": {
                "dynamicRegistration": true
            },
            "executeCommand": {
                "dynamicRegistration": true
            }
        },
        "textDocument": {
            "synchronization": {
                "dynamicRegistration": true,
                "willSave": true,
                "willSaveWaitUntil": true,
                "didSave": true
            },
            "completion": {
                "dynamicRegistration": true,
                "completionItem": {
                    "snippetSupport": true
                }
            },
            "hover": {
                "dynamicRegistration": true
            },
            "signatureHelp": {
                "dynamicRegistration": true
            },
            "references": {
                "dynamicRegistration": true
            },
            "documentHighlight": {
                "dynamicRegistration": true
            },
            "documentSymbol": {
                "dynamicRegistration": true
            },
            "formatting": {
                "dynamicRegistration": true
            },
            "rangeFormatting": {
                "dynamicRegistration": true
            },
            "onTypeFormatting": {
                "dynamicRegistration": true
            },
            "definition": {
                "dynamicRegistration": true
            },
            "codeAction": {
                "dynamicRegistration": true
            },
            "codeLens": {
                "dynamicRegistration": true
            },
            "documentLink": {
                "dynamicRegistration": true
            },
            "rename": {
                "dynamicRegistration": true
            }
        }
    },
    "trace": "verbose"
}


[Trace - 5:31:34 PM] Received response 'initialize - (0)' in 355ms.
Result: {
    "capabilities": {
        "textDocumentSync": 2,
        "hoverProvider": true,
        "completionProvider": {
            "resolveProvider": true,
            "triggerCharacters": [
                ".",
                "@",
                "#"
            ]
        },
        "definitionProvider": true,
        "referencesProvider": true,
        "documentHighlightProvider": true,
        "documentSymbolProvider": true,
        "workspaceSymbolProvider": true,
        "codeActionProvider": true,
        "codeLensProvider": {
            "resolveProvider": true
        },
        "documentFormattingProvider": true,
        "documentRangeFormattingProvider": true
    }
}


[Trace - 5:31:34 PM] Sending notification 'initialized'.
Params: {}


[Trace - 5:31:34 PM] Sending notification '$/setTraceNotification'.
Params: {
    "value": "verbose"
}


[Trace - 5:31:34 PM] Sending notification 'workspace/didChangeConfiguration'.
Params: {
    "settings": {
        "java": {
            "configuration": {
                "maven": {
                    "userSettings": null
                },
                "updateBuildConfiguration": "automatic"
            },
            "errors": {
                "incompleteClasspath": {
                    "severity": "ignore"
                }
            },
            "home": "/usr/lib/jvm/java-8-openjdk-amd64",
            "jdt": {
                "ls": {
                    "vmargs": "-noverify -Xmx1G -XX:+UseG1GC -XX:+UseStringDeduplication"
                }
            },
            "referencesCodeLens": {
                "enabled": true
            },
            "trace": {
                "server": "verbose"
            }
        }
    }
}


[Trace - 5:31:34 PM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java",
        "languageId": "java",
        "version": 1,
        "text": "public class foo {\n\n    public static void main(String[] args) {\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n        this.toString();\n    }\n}\n"
    }
}


[Trace - 5:31:34 PM] Sending request 'textDocument/codeAction - (1)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "range": {
        "start": {
            "line": 0,
            "character": 0
        },
        "end": {
            "line": 0,
            "character": 6
        }
    },
    "context": {
        "diagnostics": []
    }
}


[Trace - 5:31:34 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "5%"
}


[Trace - 5:31:34 PM] Sending request 'textDocument/codeLens - (2)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    }
}


[Trace - 5:31:37 PM] Sending request 'textDocument/hover - (3)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 4,
        "character": 17
    }
}


[Trace - 5:31:37 PM] Sending notification '$/cancelRequest'.
Params: {
    "id": 3
}


[Trace - 5:31:37 PM] Sending request 'textDocument/hover - (4)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 3,
        "character": 17
    }
}


[Trace - 5:31:37 PM] Sending request 'textDocument/documentHighlight - (5)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 3,
        "character": 17
    }
}


[Trace - 5:31:37 PM] Sending notification '$/cancelRequest'.
Params: {
    "id": 4
}


[Trace - 5:31:38 PM] Sending request 'textDocument/codeAction - (6)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "range": {
        "start": {
            "line": 3,
            "character": 13
        },
        "end": {
            "line": 3,
            "character": 21
        }
    },
    "context": {
        "diagnostics": []
    }
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "8%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "12%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "15%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "50%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "53%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "57%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Starting",
    "message": "100%"
}


[Trace - 5:31:38 PM] Received notification 'language/status'.
Params: {
    "type": "Started",
    "message": "Ready"
}


[Trace - 5:31:40 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///tmp/vscodesws_4610e/jdt_ws/jdt.ls-java-project/src/foo.java",
    "diagnostics": []
}


[Trace - 5:31:40 PM] Received response 'textDocument/hover - (3)' in 2951ms. Request failed: The request (id: 3, method: 'textDocument/hover') has been cancelled (-32800).
[Trace - 5:31:40 PM] Received response 'textDocument/hover - (4)' in 2546ms. Request failed: The request (id: 4, method: 'textDocument/hover') has been cancelled (-32800).
[Trace - 5:31:40 PM] Received response 'textDocument/codeLens - (2)' in 5781ms.
Result: [
    {
        "range": {
            "start": {
                "line": 2,
                "character": 23
            },
            "end": {
                "line": 2,
                "character": 27
            }
        },
        "data": [
            "file:///home/sasha/foo.java",
            {
                "line": 2,
                "character": 23
            }
        ]
    },
    {
        "range": {
            "start": {
                "line": 0,
                "character": 13
            },
            "end": {
                "line": 0,
                "character": 16
            }
        },
        "data": [
            "file:///home/sasha/foo.java",
            {
                "line": 0,
                "character": 13
            }
        ]
    }
]


[Trace - 5:31:40 PM] Received response 'textDocument/codeAction - (1)' in 6037ms.
Result: []


[Trace - 5:31:40 PM] Received response 'textDocument/codeAction - (6)' in 2128ms.
Result: []


[Trace - 5:31:40 PM] Received response 'textDocument/documentHighlight - (5)' in 2647ms.
Result: []


[Trace - 5:31:40 PM] Sending request 'codeLens/resolve - (7)'.
Params: {
    "range": {
        "start": {
            "line": 0,
            "character": 13
        },
        "end": {
            "line": 0,
            "character": 16
        }
    },
    "data": [
        "file:///home/sasha/foo.java",
        {
            "line": 0,
            "character": 13
        }
    ]
}


[Trace - 5:31:40 PM] Sending request 'codeLens/resolve - (8)'.
Params: {
    "range": {
        "start": {
            "line": 2,
            "character": 23
        },
        "end": {
            "line": 2,
            "character": 27
        }
    },
    "data": [
        "file:///home/sasha/foo.java",
        {
            "line": 2,
            "character": 23
        }
    ]
}


[Trace - 5:31:40 PM] Received response 'codeLens/resolve - (7)' in 264ms.
Result: {
    "range": {
        "start": {
            "line": 0,
            "character": 13
        },
        "end": {
            "line": 0,
            "character": 16
        }
    },
    "command": {
        "title": "0 references",
        "command": "java.show.references",
        "arguments": [
            "file:///home/sasha/foo.java",
            {
                "line": 0,
                "character": 13
            },
            []
        ]
    },
    "data": [
        "file:///home/sasha/foo.java",
        {
            "line": 0,
            "character": 13
        }
    ]
}


[Trace - 5:31:41 PM] Received response 'codeLens/resolve - (8)' in 464ms.
Result: {
    "range": {
        "start": {
            "line": 2,
            "character": 23
        },
        "end": {
            "line": 2,
            "character": 27
        }
    },
    "command": {
        "title": "0 references",
        "command": "java.show.references",
        "arguments": [
            "file:///home/sasha/foo.java",
            {
                "line": 2,
                "character": 23
            },
            []
        ]
    },
    "data": [
        "file:///home/sasha/foo.java",
        {
            "line": 2,
            "character": 23
        }
    ]
}


[Trace - 5:31:44 PM] Sending request 'textDocument/hover - (9)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 11,
        "character": 20
    }
}


[Trace - 5:31:44 PM] Sending notification '$/cancelRequest'.
Params: {
    "id": 9
}


[Trace - 5:31:44 PM] Received response 'textDocument/hover - (9)' in 189ms. Request failed: The request (id: 9, method: 'textDocument/hover') has been cancelled (-32800).
[Trace - 5:31:45 PM] Sending request 'textDocument/hover - (10)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 7,
        "character": 18
    }
}


[Trace - 5:31:45 PM] Received response 'textDocument/hover - (10)' in 25ms.
Result: {
    "contents": [
        ""
    ]
}


[Trace - 5:31:51 PM] Sending request 'textDocument/hover - (11)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 6,
        "character": 17
    }
}


[Trace - 5:31:51 PM] Received response 'textDocument/hover - (11)' in 105ms.
Result: {
    "contents": [
        ""
    ]
}


[Trace - 5:31:51 PM] Sending request 'textDocument/documentHighlight - (12)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 6,
        "character": 17
    }
}


[Trace - 5:31:51 PM] Received response 'textDocument/documentHighlight - (12)' in 7ms.
Result: []


[Trace - 5:31:51 PM] Sending request 'textDocument/codeAction - (13)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "range": {
        "start": {
            "line": 6,
            "character": 13
        },
        "end": {
            "line": 6,
            "character": 21
        }
    },
    "context": {
        "diagnostics": []
    }
}


[Trace - 5:31:52 PM] Received response 'textDocument/codeAction - (13)' in 4ms.
Result: []


[Trace - 5:31:55 PM] Sending request 'textDocument/documentHighlight - (14)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 9,
        "character": 14
    }
}


[Trace - 5:31:55 PM] Received response 'textDocument/documentHighlight - (14)' in 7ms.
Result: []


[Trace - 5:31:55 PM] Sending request 'textDocument/definition - (15)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 9,
        "character": 14
    }
}


[Trace - 5:31:55 PM] Received response 'textDocument/definition - (15)' in 86ms.
Result: [
    {
        "range": {}
    }
]


[Trace - 5:31:55 PM] Sending request 'textDocument/codeAction - (16)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "range": {
        "start": {
            "line": 0,
            "character": 0
        },
        "end": {
            "line": 20,
            "character": 0
        }
    },
    "context": {
        "diagnostics": []
    }
}


[Trace - 5:31:55 PM] Received response 'textDocument/codeAction - (16)' in 2ms.
Result: []


[Trace - 5:31:55 PM] Sending request 'textDocument/definition - (17)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 9,
        "character": 14
    }
}


[Trace - 5:31:55 PM] Received response 'textDocument/definition - (17)' in 14ms.
Result: [
    {
        "range": {}
    }
]


[Trace - 5:31:55 PM] Sending request 'textDocument/definition - (18)'.
Params: {
    "textDocument": {
        "uri": "file:///home/sasha/foo.java"
    },
    "position": {
        "line": 8,
        "character": 12
    }
}


[Trace - 5:31:55 PM] Received response 'textDocument/definition - (18)' in 34ms.
Result: [
    {
        "range": {}
    }
]

I think this is caused by the class not being compilable. You're calling this in a static method. The class being standalone, compilation errors are not reported.

If you remove the static keyword from the main method, highlighting works (at least for me)

Now double click at "toString" works, but double click at "this" doesn't. Please, check.

@fadeevab

@fadeevab indeed, this is not highlighted, this is the same behaviour in Eclipse. It might be done on purpose (no idea), I asked the question on https://bugs.eclipse.org/bugs/show_bug.cgi?id=518397

@fbricon

@fbricon, Ok, but still unclear for me this ideology: why to not just highlight the same occurrences which are highlighted inside the editor regardless to the ability to compile the Java file by the server?

Hm, I got the confusion: there are 2 types of highlighting - single click and custom selection (double click).
At single click server finds the symbols and highlightings.
While the custom selection editor highlights everything it found, and scroll bar shows all the occurrences.

(Edited) No matter double click or custom selection: it's ok to select some range of symbols and all coincides should be highlighted - but they are not.

@fbricon

@fbricon , I'm not sure I was clear in my comment, so I want to clarify: I assume that the "custom selection" isn't highlighted on the scroll bar while it should be highlighted (I mean the case when you select a word or a part of word and it's highlighted across the document). The "single click" is highlighted correctly the same way Eclipse has and it's ok.

I found out that the custom selection is being highlighted on the scroll bar as long as the initialization logs are being printed into output screen. Opening of another file doesn't matter: just wait for a while after you open a Java file.

Closing this issue as out of date and unlikely to be implemented

Navigation Menu

Repository navigation

Selection occurrences are not highlighted at the vertical scroll bar #240

Environment

Steps To Reproduce

Current Result

Expected Result

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Selection occurrences are not highlighted at the vertical scroll bar #240

Description

Environment

Steps To Reproduce

Current Result

Expected Result

Activity

fbricon commented on Jun 15, 2017

fbricon commented on Jun 15, 2017

fadeevab commented on Jun 15, 2017

aeschli commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fbricon commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fadeevab commented on Jun 16, 2017

fadeevab commented on Jun 19, 2017

robstryker commented on Oct 28, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions