fix(e2e): skip failswitch on operator and use NAME_SPACE by rostalan · Pull Request #5205 · redhat-developer/rhdh

rostalan · 2026-08-03T11:26:34Z

Operator jobs skip orchestrator workflow deploy, so failswitch should follow greeting/all-runs and fixme there. Also target process.env.NAME_SPACE for the in-cluster httpbin mock instead of the Playwright project name.

rhdh-qodo-merge · 2026-08-03T11:27:46Z

PR Summary by Qodo

Fix Orchestrator failswitch e2e: skip on Operator jobs and read NAME_SPACE

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

AI Description

• Mark failswitch workflow e2e as fixme for Operator jobs missing orchestrator deploy.
• Resolve namespace selection by using NAME_SPACE env var for in-cluster httpbin.
• Simplify test signature by removing unused Playwright testInfo dependency.

Diagram

graph TD
  A["CI job"] --> B["Job-name matcher"] --> C["Playwright: failswitch spec"] --> D["Orchestrator UI/API"] --> E[("K8s namespace")]
  C --> F["httpbin mock"]

  subgraph Legend
    direction LR
    _ci["CI/job"] ~~~ _test["Test spec"] ~~~ _svc["Service/endpoint"] ~~~ _db[("Cluster scope")]
  end

High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize namespace resolution in a Playwright fixture

➕ Avoids repeated env-var access across specs
➕ Enables consistent validation/error messaging when NAME_SPACE is missing
➕ Makes swapping local vs in-cluster namespaces easier
➖ Requires additional plumbing and refactors across multiple tests
➖ May be overkill if only a small subset of specs needs NAME_SPACE

2. Gate Operator-specific behavior via project config instead of job-name matching

➕ More explicit and test-runner-native than relying on CI job naming conventions
➕ Easier to run locally by selecting a project
➖ Doesn’t solve cases where CI job skips orchestrator deploy but uses same project
➖ Still needs a reliable namespace source for in-cluster mocks

Recommendation: The current approach is appropriate for an immediate stabilization: explicitly marking the spec as fixme for Operator jobs prevents false failures where orchestrator deployment is absent, and switching to NAME_SPACE aligns namespace selection with cluster reality. If more specs start needing NAME_SPACE or job-based gating, consider extracting a shared fixture/config layer to reduce duplication and make environment requirements more discoverable.

Files changed (1) +7 / -2

Bug fix (1) +7 / -2

failswitch-workflow.spec.tsSkip failswitch e2e on Operator jobs and use NAME_SPACE for namespace +7/-2

Skip failswitch e2e on Operator jobs and use NAME_SPACE for namespace
• Adds a fixme gate to disable the suite when running in Operator CI jobs (pending an upstream bug fix). Updates namespace selection to read process.env.NAME_SPACE (and skips when unset) instead of relying on the Playwright project name; also removes the unused testInfo parameter.
e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts

rhdh-qodo-merge · 2026-08-03T11:31:34Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. test.fixme TODO link wrong ✓ Resolved 📜 Skill insight ✧ Quality

Description

The newly added test.fixme() is preceded by a TODO comment, but the link uses
https://issues.redhat.com/... instead of the required Jira format
https://redhat.atlassian.net/browse/RHDHBUGS-XXXX. This breaks the mandated traceability for
fixme-skipped tests.

Code

e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts[R15-16]
+  // TODO: https://issues.redhat.com/browse/RHDHBUGS-2184 fix orchestrator tests on Operator deployment
+  test.fixme(() => skipIfJobName(JOB_NAME_PATTERNS.OPERATOR));

Relevance

● Weak
Repo fixme TODOs use issues.redhat.com links (PR #3508); Jira-link cleanup PR #4173 didn’t enforce
atlassian format.
PR-#3508
PR-#4173

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The checklist requires test.fixme() to be immediately preceded by a TODO comment with a Jira link
in the https://redhat.atlassian.net/browse/RHDHBUGS-XXXX format. The added TODO comment uses
https://issues.redhat.com/browse/RHDHBUGS-2184, which does not match the required format.

e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts[15-16]
Skill: e2e-diagnose-and-fix

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`test.fixme()` must be immediately preceded by a TODO comment linking to a Jira ticket in the exact required format: `// TODO: https://redhat.atlassian.net/browse/RHDHBUGS-XXXX`.

## Issue Context
In `failswitch-workflow.spec.ts`, the TODO link currently points to `https://issues.redhat.com/browse/...`, which does not meet the compliance rule format requirement.

## Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts[15-16]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Context used

✅ Compliance rules (platform): 46 rules

✅ Skills: e2e-verify-fix, e2e-diagnose-and-fix

✅ Cross-repo context

Explored: repo: redhat-developer/rhdh-operator (branch: release-1.9, sha: 59fdf8d5)

Not relevant to this PR: redhat-developer/rhdh-plugins

Not relevant to this PR: redhat-developer/rhdh-chart

Not relevant to this PR: redhat-developer/rhdh-local

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

github-actions · 2026-08-03T11:35:09Z

The container image build workflow finished with status: cancelled.

rostalan · 2026-08-03T11:37:53Z

/test e2e-ocp-operator

rostalan · 2026-08-03T11:38:38Z

/test

rostalan · 2026-08-03T11:39:01Z

/test e2e-ocp-operator-nightly

github-actions · 2026-08-03T12:16:59Z

Image was built and published successfully. It is available at:

rostalan · 2026-08-04T08:02:59Z

/test e2e-ocp-operator-nightly

rostalan · 2026-08-04T12:52:47Z

/test e2e-ocp-operator-nightly

zdrapela · 2026-08-04T13:59:37Z

 type EnvEntry = { name: string; value: string };

 test.describe("Orchestrator failswitch workflow tests", () => {
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2184 fix orchestrator tests on Operator deployment


The TODO mentions an already closed issue (https://redhat.atlassian.net/browse/RHDHBUGS-2184). It was closed as already fixed on Overlays. Can you please update the link and/or create a new issue specifically for this branch for tracking?

github-actions · 2026-08-04T14:11:58Z

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

zdrapela · 2026-08-04T14:12:12Z

/lgtm

rostalan · 2026-08-05T07:34:07Z

/test e2e-ocp-helm

rostalan · 2026-08-05T09:07:04Z

/test e2e-ocp-helm

rostalan · 2026-08-06T07:27:03Z

/test e2e-ocp-helm

rostalan · 2026-08-06T08:12:11Z

/test e2e-ocp-helm

Operator jobs skip orchestrator workflow deploy, so failswitch should follow greeting/all-runs and fixme there. Also target process.env.NAME_SPACE for the in-cluster httpbin mock instead of the Playwright project name. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Replace closed RHDHBUGS-2184 with the open tracking issue. Co-authored-by: Cursor <cursoragent@cursor.com>

openshift-ci · 2026-08-06T08:32:45Z

New changes are detected. LGTM label has been removed.

rostalan · 2026-08-06T08:32:58Z

/test e2e-ocp-helm

openshift-ci · 2026-08-06T08:33:19Z

@rostalan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-operator-nightly	`5c89cc1`	link	false	`/test e2e-ocp-operator-nightly`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sonarqubecloud · 2026-08-06T08:33:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-08-06T09:15:07Z

Image was built and published successfully. It is available at:

rostalan · 2026-08-10T08:23:38Z

/test e2e-ocp-helm

rostalan · 2026-08-10T09:29:41Z

/test e2e-ocp-operator

rostalan · 2026-08-10T09:30:04Z

/test e2e-ocp-operator-nightly

openshift-ci Bot requested review from josephca and subhashkhileri August 3, 2026 11:26

rhdh-qodo-merge Bot added Tests Bug fix labels Aug 3, 2026

zdrapela reviewed Aug 4, 2026

View reviewed changes

openshift-ci Bot assigned zdrapela Aug 4, 2026

openshift-ci Bot added the lgtm label Aug 4, 2026

rostalan and others added 3 commits August 6, 2026 10:32

fix(e2e): use Atlassian Jira URL in failswitch fixme TODO

75ec7e5

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(e2e): point failswitch operator TODO to RHDHBUGS-3555

fcf91d8

Replace closed RHDHBUGS-2184 with the open tracking issue. Co-authored-by: Cursor <cursoragent@cursor.com>

rostalan force-pushed the fix/failswitch-e2e-operator-ns-release-1.9 branch from bdfa46b to fcf91d8 Compare August 6, 2026 08:32

openshift-ci Bot removed the lgtm label Aug 6, 2026

Uh oh!

Conversation

rostalan commented Aug 3, 2026

Uh oh!

rhdh-qodo-merge Bot commented Aug 3, 2026

PR Summary by Qodo

Uh oh!

rhdh-qodo-merge Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

rostalan commented Aug 3, 2026

Uh oh!

rostalan commented Aug 3, 2026

Uh oh!

rostalan commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

rostalan commented Aug 4, 2026

Uh oh!

rostalan commented Aug 4, 2026

Uh oh!

zdrapela Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

zdrapela commented Aug 4, 2026

Uh oh!

rostalan commented Aug 5, 2026

Uh oh!

rostalan commented Aug 5, 2026

Uh oh!

rostalan commented Aug 6, 2026

Uh oh!

rostalan commented Aug 6, 2026

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

rostalan commented Aug 6, 2026

Uh oh!

openshift-ci Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 6, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

rostalan commented Aug 10, 2026

Uh oh!

rostalan commented Aug 10, 2026

Uh oh!

rostalan commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rhdh-qodo-merge Bot commented Aug 3, 2026 •

edited

Loading

zdrapela Aug 4, 2026 •

edited

Loading

openshift-ci Bot commented Aug 6, 2026 •

edited

Loading