fix(ci): pull-ci-redhat-developer-rhdh-main-e2e-osd-gcp-operator-nightly#4419
Conversation
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
The container image build workflow finished with status: |
|
The container image build workflow finished with status: |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-ocp-helm |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
1 similar comment
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-osd-gcp-operator-nightly |
Fortune-Ndlovu
changed the title
|
/agentic_review |
|
Persistent review updated to latest commit e3d46d2 |
…oyment-not-starting-fix
- Fix comment mismatch: update diff files to reference fix_ghcr_oci_urls_for_osd_gcp() - Add error handling: fix_ghcr_oci_urls_for_osd_gcp now fails fast with || return 1 - Add yq dedup after sed rewrite to prevent duplicate orchestrator plugin entries Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
while deployment fix is working. No more init container crashes, no more {{inherit}} errors, no more ghcr.io timeouts, no more CrashLoopBackOff. The operator deployment reached the "Running" state successfully. Our fix is very messy, we may need an alternative solution, even if we have gh time out issues with OSD, open to suggestions |
Replace the 40-line sed function with hardcoded per-plugin versions
with a single generic yq command that adds !<plugin-path> suffixes to
all ghcr.io OCI URLs. This skips skopeo inspect (which times out on
OSD-GCP) without hardcoding versions that need manual maintenance.
Revert OSD-GCP diff files to match OCP: restore {{inherit}} tags and
remove includes: [] override, since the operator init container
resolves {{inherit}} from dynamic-plugins.default.yaml identically
to OCP.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-ocp-helm |
|
/test e2e-osd-gcp-operator-nightly |
…h suffix" This reverts commit cef223d.
…oyment-not-starting-fix
|
The container image build workflow finished with status: |
|
|
/test e2e-osd-gcp-operator-nightly |
|
/test e2e-ocp-helm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4419 +/- ##
=======================================
Coverage ? 69.56%
=======================================
Files ? 109
Lines ? 4705
Branches ? 511
=======================================
Hits ? 3273
Misses ? 1432
Partials ? 0
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@Fortune-Ndlovu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # (operator init container lacks dynamic-plugins.default.yaml to resolve {{inherit}}) | ||
| # 2. Adds !<plugin-path> suffixes to non-inherit ghcr.io plugins to skip skopeo inspect | ||
| # Versions sourced from quay.io/rhdh/plugin-catalog-index:1.10. | ||
| fix_ghcr_oci_urls_for_osd_gcp() { |
There was a problem hiding this comment.
now thinking, if we add the plugin directory path to the dpdy file in the catalog index this would fix this issue because we would avoid having to make calls to the ghcr to get the oci manifest using skopeo inspect and go straight to skopeo copy
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
4 participants
Description
fix(ci): pull-ci-redhat-developer-rhdh-main-e2e-osd-gcp-operator-nightly
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer