[WIP] test: tests for github events module#3948
[WIP] test: tests for github events module#394804kash wants to merge 10 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
There was a problem hiding this comment.
Is this the correct place for adding the config related to the Events System? The required config is mentioned in the docs here: https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.8/html/configuring_dynamic_plugins/configuring-rhdh-events-module#proc-configuring-events-module-for-github
There was a problem hiding this comment.
yep those are the same configs used in the upstream docs:
| const catalogRepoDetails = { | ||
| name: catalogRepoName, | ||
| url: `github.com/janus-test/${catalogRepoName}`, | ||
| org: "github.com/janus-test", |
There was a problem hiding this comment.
Is it fine to use the janus-test org for these tests or should I be using another one?
There was a problem hiding this comment.
we should prob have these these placed somewhere the team has access/control to. We can probably discuss a location for this when everyone is back.
04kash
force-pushed
the
events-module-e2e-tests
branch
from
33666c1 to
909b63c
Compare
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
04kash
force-pushed
the
events-module-e2e-tests
branch
from
909b63c to
77614f7
Compare
|
The image is available at: /test e2e-ocp-helm |
04kash
changed the title
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
|
The image is available at: /test e2e-ocp-helm |
|
@04kash: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
04kash
force-pushed
the
events-module-e2e-tests
branch
from
8d731a1 to
e8d03a2
Compare
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
|
|
The image is available at: |
|
Closing this one as we're adding these tests to the overlay repo instead: redhat-developer/rhdh-plugin-export-overlays#1906 |
3 participants
Description
E2E tests for the Github Events Module.
Which issue(s) does this PR fix
Fixes: https://issues.redhat.com/browse/RHIDP-9718
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer