feat(skill-maker,rhdh-jira): hard-require grilling and fix customer field guidance - #77
Open
schultzp2020 wants to merge 3 commits into
Open
feat(skill-maker,rhdh-jira): hard-require grilling and fix customer field guidance#77schultzp2020 wants to merge 3 commits into
schultzp2020 wants to merge 3 commits into
Conversation
…ield guidance Create/interview paths gate on Matt Pocock's grilling skill with setup checks, invoke it for cadence, and keep domain questions local. rhdh-jira encodes customer-identity and RHDH-Customer label rules from RHDHPLAN-1661 feedback; skill-maker discloses audit/create branches and adds skill-quality guidance. Also run base-images shell tests via bash on Windows so pre-commit pytest passes.
Add a local work-breakdown reference (synthesize-then-gap-fill, tracer bullets, blocking edges, quiz before create) and wire it into Feature/Epic decomposition — inspiration only, no hard dep on Matt's skills.
Keep tracer-bullet / synthesize guidance; remove references to upstream skill names so the reference stands alone.
|
@schultzp2020 I'm not a skill expert yet, but the updated guidance looks like it should address those two points, thanks for wrapping that in. Did you try running the revised logic or audit against RHDHPLAN-1661 to see if it would handle the Customer Considerations section differently now (or flag that a name was included)? Have you seen it successfully manipulate security level before? It's not very specific here, but as long as it reliably picks "Red Hat Employee" when trying to restrict visibility, we should be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grillingskill on skill-maker create/interview and rhdh-jira create paths (to-feature/to-epic/to-issue), with setup detect + confirm/install dialogue; cadence via invokinggrilling, domain questions stay local.RHDH-Customerlabel (authoritative infields.md, enforced on create/grill).skill-quality.md, rewritten description) and document the grilling prereq + full Matt pack recommendation in the README.Test plan
uv run pytest tests/unit/test_skill_maker_grilling_setup.py tests/unit/test_rhdh_jira_grilling_setup.py tests/unit/test_base_images_and_rpms.pypytest) pass on committo-featurewith customer context → support key +RHDH-Customerlabel, no customer name in summary/description