Skip to content

chore(x2a): remove unused code#2528

Merged
elai-shalev merged 1 commit intoredhat-developer:mainfrom
mareklibra:cleanUp
Mar 12, 2026
Merged

chore(x2a): remove unused code#2528
elai-shalev merged 1 commit intoredhat-developer:mainfrom
mareklibra:cleanUp

Conversation

@mareklibra
Copy link
Member

@mareklibra mareklibra commented Mar 12, 2026

Remove useSeedTestData since it's no longer needed in this phase of development.

Let's keep the POST /projects/{projectId}/modules orphan until we have proper sync logic (FLPATH-3214) implemented. It still might be useful in scripts.

Signed-off-by: Marek Libra <marek.libra@gmail.com>
@rhdh-qodo-merge
Copy link

Review Summary by Qodo

Remove unused useSeedTestData hook and cleanup

📦 Other

Grey Divider

Walkthroughs

Description
• Remove unused useSeedTestData hook and its mock
• Delete 133-line test data seeding utility file
• Clean up associated test mock in ProjectList tests
Diagram
flowchart LR
  A["useSeedTestData.ts<br/>133 lines"] -->|deleted| B["Codebase cleanup"]
  C["ProjectList.test.tsx<br/>jest.mock removed"] -->|simplified| B
Loading

Grey Divider

File Changes

1. workspaces/x2a/plugins/x2a/src/useSeedTestData.ts Cleanup +0/-133

Delete useSeedTestData hook file

• Entire file deleted (133 lines)
• Removed React hook for seeding test data
• Eliminated project, module, and job creation logic
• Removed placeholder authentication and test data utilities

workspaces/x2a/plugins/x2a/src/useSeedTestData.ts


2. workspaces/x2a/plugins/x2a/src/components/ProjectList/ProjectList.test.tsx 🧪 Tests +0/-4

Remove useSeedTestData mock from tests

• Removed jest.mock for useSeedTestData
• Deleted 4 lines of unused mock setup
• Simplified test file dependencies

workspaces/x2a/plugins/x2a/src/components/ProjectList/ProjectList.test.tsx


Grey Divider

Qodo Logo

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Mar 12, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Mar 12, 2026

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-x2a

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-x2a workspaces/x2a/plugins/x2a none v1.0.2

@sonarqubecloud
Copy link

@elai-shalev elai-shalev merged commit c8b1846 into redhat-developer:main Mar 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants