perf(scripts): speed up RHDH operator install using install-rhdh-catalog-source.sh (~30 min → ~2 min)

[subhashkhileri]

JIRA : https://redhat.atlassian.net/browse/RHIDP-13676

Summary

• Skips slow skopeo inspect (~42s/bundle) — attempts the copy directly; failed copies (~3s) are faster than successful inspects, so images that don't exist on quay are handled with minimal overhead
• Parallel bundle processing with MAX_PARALLEL=10 (env-overridable)
• Parallel opm render + registry setup — these two phases are independent, so they now run concurrently; bundle processing waits until both are done
• Atomic render.yaml updates — each worker writes a per-bundle .sed file (keyed by digest, no locking needed); all replacements are applied in a single sed -f pass after all workers complete
• --ignore-not-found replaces the check-then-delete secret pattern
• Force OLM re-index by deleting the CatalogSource before recreating it — without this, OLM skips re-indexing when the tag is unchanged but the image digest changed (rebuilt IIB)
• Fail loudly if any bundle fails to process (was: silent error log + continue)

Assisted-by: Claude Code

[rhdh-qodo-merge]

Code Review by Qodo

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again

[rhdh-qodo-merge]

Review Summary by Qodo

Parallelize IIB bundle processing for ~5x performance improvement

✨ Enhancement

Walkthroughs

Description

• Parallelizes bundle processing with configurable MAX_PARALLEL (default 10)
  - Uses portable kill -0 throttle loop to manage concurrent workers
  - Skips expensive skopeo inspect; attempts copy directly instead
• Runs opm render and registry setup concurrently before bundle processing
• Applies sed replacements atomically in single pass after all workers complete
• Replaces check-then-delete pattern with --ignore-not-found flag
• Forces OLM re-indexing by deleting CatalogSource before recreation
• Fails loudly on bundle processing errors instead of silent continuation

Diagram

flowchart LR
  A["Bundle Images"] --> B["Parallel Bundle Processing<br/>MAX_PARALLEL=10"]
  C["opm render"] --> D["Registry Setup"]
  C --> E["Wait for Both"]
  D --> E
  E --> B
  B --> F["Collect sed Files"]
  F --> G["Apply Atomic<br/>Replacements"]
  G --> H["Regenerate IIB"]
  H --> I["Delete & Recreate<br/>CatalogSource"]

Loading

File Changes

1. .rhdh/scripts/install-rhdh-catalog-source.sh ✨ Enhancement +118/-43

Parallelize bundle processing and optimize registry operations

• Added MAX_PARALLEL environment variable (default 10) for controlling concurrent bundle processing
• Extracted bundle processing logic into new process_bundle() function that handles pull, rewrite,
 repack, and push operations
• Refactored update_refs_in_iib_bundles() to spawn parallel workers with kill -0 throttle loop
 instead of sequential processing
• Collects per-bundle sed files and applies them atomically in single pass after all workers
 complete
• Parallelized opm render and registry setup phases using background job with wait
• Replaced check-then-delete secret pattern with --ignore-not-found flag for cleaner code
• Added CatalogSource deletion before recreation to force OLM re-indexing on digest changes
• Added error handling to fail loudly when bundle processing fails

.rhdh/scripts/install-rhdh-catalog-source.sh

---

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud