Skip to content

fix: prevent github from scanning test secrets - #362

Merged
adietish merged 1 commit into
redhat-developer:mainfrom
adietish:github_secret_scanning_path_exclusions
Aug 12, 2026
Merged

fix: prevent github from scanning test secrets#362
adietish merged 1 commit into
redhat-developer:mainfrom
adietish:github_secret_scanning_path_exclusions

Conversation

@adietish

@adietish adietish commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

prevents github from complaining about secrets in our tests. see src/test/resources/tls

@adietish adietish self-assigned this Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@adietish, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c747bec9-4234-4797-a694-69b1e34132f5

📥 Commits

Reviewing files that changed from the base of the PR and between c0a68ae and 4fa25ee.

📒 Files selected for processing (1)
  • .github/secret_scanning.yml
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated security scanning configuration to exclude TLS certificate test resources from secret scanning.

Walkthrough

The GitHub secret-scanning configuration excludes TLS certificate test resources under src/test/resources/tls/*.

Changes

Secret scanning configuration

Layer / File(s) Summary
TLS test resource exclusion
.github/secret_scanning_path_exclusions.json
Adds the test-tls-certs exclusion for src/test/resources/tls/*.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: azatsarynnyy, vrubezhny

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so its relation to the changeset cannot be assessed. Add a brief description that states the TLS test-resource path exclusion and its purpose.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the change that prevents GitHub secret scanning from scanning test secrets.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adietish
adietish force-pushed the github_secret_scanning_path_exclusions branch from c0a68ae to 66faa1f Compare August 12, 2026 04:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/secret_scanning_path_exclusions.json:
- Around line 3-4: Narrow the secret-scanning exclusion named test-tls-certs
from the entire src/test/resources/tls/* directory to only the specific
non-sensitive fixture files required by tests. Ensure private keys, credentials,
and other unapproved files in that directory remain subject to scanning.
- Around line 1-6: Replace the unsupported
.github/secret_scanning_path_exclusions.json configuration with
.github/secret_scanning.yml, defining the existing src/test/resources/tls/*
exclusion under the paths-ignore key while preserving the test-tls-certs
exclusion.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7a960d4a-362e-40c4-97f6-eadf5d6f6376

📥 Commits

Reviewing files that changed from the base of the PR and between c2d489a and c0a68ae.

📒 Files selected for processing (1)
  • .github/secret_scanning_path_exclusions.json

Comment thread .github/secret_scanning_path_exclusions.json Outdated
Comment thread .github/secret_scanning_path_exclusions.json Outdated
@codecov-commenter

codecov-commenter commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.04%. Comparing base (71098f6) to head (4fa25ee).
⚠️ Report is 416 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #362       +/-   ##
==========================================
+ Coverage   0.00%   35.04%   +35.04%     
==========================================
  Files          4      113      +109     
  Lines         26     4916     +4890     
  Branches       0      945      +945     
==========================================
+ Hits           0     1723     +1723     
- Misses        26     2941     +2915     
- Partials       0      252      +252     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
adietish force-pushed the github_secret_scanning_path_exclusions branch from 66faa1f to 4fa25ee Compare August 12, 2026 04:47
@adietish
adietish merged commit 1167771 into redhat-developer:main Aug 12, 2026
7 checks passed
@adietish
adietish deleted the github_secret_scanning_path_exclusions branch August 12, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants