fix: prevent github from scanning test secrets - #362
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe GitHub secret-scanning configuration excludes TLS certificate test resources under ChangesSecret scanning configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c0a68ae to
66faa1f
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/secret_scanning_path_exclusions.json:
- Around line 3-4: Narrow the secret-scanning exclusion named test-tls-certs
from the entire src/test/resources/tls/* directory to only the specific
non-sensitive fixture files required by tests. Ensure private keys, credentials,
and other unapproved files in that directory remain subject to scanning.
- Around line 1-6: Replace the unsupported
.github/secret_scanning_path_exclusions.json configuration with
.github/secret_scanning.yml, defining the existing src/test/resources/tls/*
exclusion under the paths-ignore key while preserving the test-tls-certs
exclusion.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a960d4a-362e-40c4-97f6-eadf5d6f6376
📒 Files selected for processing (1)
.github/secret_scanning_path_exclusions.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 0.00% 35.04% +35.04%
==========================================
Files 4 113 +109
Lines 26 4916 +4890
Branches 0 945 +945
==========================================
+ Hits 0 1723 +1723
- Misses 26 2941 +2915
- Partials 0 252 +252 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
66faa1f to
4fa25ee
Compare
prevents github from complaining about secrets in our tests. see src/test/resources/tls