Skip to content

perf: filter source networks using overrides in network mapping #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertoflorez wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: filter source networks using overrides in network mapping #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7409484
perf: optimize network map creation by filtering networks before proc…
May 26, 2026
21d352e
chore: trigger validation
May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions roles/mtv_management/tasks/_mtv_network_map.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,22 @@
mtv_management_inventory_query_endpoint: /providers/openshift/{{ (mtv_providers.openshift | selectattr('name', 'equalto', mtv_management_destination_target) | first).uid }}/networkattachmentdefinitions?detail=4 # noqa: yaml[line-length]
mtv_management_inventory_query_result_var: mtv_networkattachmentdefinitions

- name: _mtv_network_map | Extract allowed network IDs from overrides
ansible.builtin.set_fact:
mtv_allowed_ids: "{{ mtv_management_network_map_overrides | selectattr('include', 'defined') | selectattr('include', 'equalto', true) | map(attribute='id') | list }}"
when:
- mtv_management_network_map_overrides is defined
- mtv_management_network_map_overrides | length > 0

- name: _mtv_network_map | Process VMware Networks
ansible.builtin.include_tasks: _mtv_network_map_process_network.yml
loop: "{{ mtv_networks }}"
# If overrides exist, filter mtv_networks by the allowed IDs; otherwise, use the full list.
loop: >-
{{
(mtv_networks | selectattr('id', 'in', mtv_allowed_ids | default([])) | list)
if (mtv_management_network_map_overrides | default([]) | length > 0)
else mtv_networks
}}
loop_control:
loop_var: mtv_vmware_network
when:
Expand All @@ -44,7 +57,12 @@

- name: _mtv_network_map | Process Ovirt Networks
ansible.builtin.include_tasks: _mtv_network_map_process_network.yml
loop: "{{ mtv_networks }}"
loop: >-
{{
(mtv_networks | selectattr('id', 'in', mtv_allowed_ids | default([])) | list)
if (mtv_management_network_map_overrides | default([]) | length > 0)
else mtv_networks
}}
loop_control:
loop_var: mtv_ovirt_network
when:
Expand Down
Loading