feat: add secure credential management with Vault#23
Open
stevefulme1 wants to merge 1 commit intoredhat-cop:mainfrom
Open
feat: add secure credential management with Vault#23stevefulme1 wants to merge 1 commit intoredhat-cop:mainfrom
stevefulme1 wants to merge 1 commit intoredhat-cop:mainfrom
Conversation
Adds Ansible Vault example file for encrypting sensitive inventory variables, comprehensive credential management documentation covering the AAP credential types architecture, and .gitignore patterns to prevent accidental commit of vault password and encrypted files. Resolves: MFG-380 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
sabre1041
requested changes
Apr 12, 2026
Contributor
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
Looking good. A few suggestions
| # To edit an encrypted file: | ||
| # ansible-vault edit inventory.vault.yml | ||
| # | ||
| # To use with a playbook: |
Contributor
There was a problem hiding this comment.
Any interest in showing an example with ansible-navigator?
|
|
||
| ## Architecture Overview | ||
|
|
||
| The Migration Factory uses a layered approach to credential management: |
Contributor
There was a problem hiding this comment.
Suggested change
| The Migration Factory uses a layered approach to credential management: | |
| The Ansible for OpenShift Virtualization Migration uses a layered approach to credential management: |
| @@ -0,0 +1,236 @@ | |||
| # Secure Credential Management | |||
|
|
|||
| This document describes how the OpenShift Virtualization Migration | |||
Contributor
There was a problem hiding this comment.
Suggested change
| This document describes how the OpenShift Virtualization Migration | |
| This document describes how the Ansible for OpenShift Virtualization Migration |
| # Secure Credential Management | ||
|
|
||
| This document describes how the OpenShift Virtualization Migration | ||
| Factory manages sensitive credentials and the recommended practices for |
Contributor
There was a problem hiding this comment.
Suggested change
| Factory manages sensitive credentials and the recommended practices for | |
| manages sensitive credentials and the recommended practices for |
|
|
||
| ## Credential Inventory | ||
|
|
||
| The following credentials are managed by the Migration Factory: |
Contributor
There was a problem hiding this comment.
Suggested change
| The following credentials are managed by the Migration Factory: | |
| The following credentials are managed by the Ansible for OpenShift Virtualization Migration: |
|
|
||
| The following credentials are managed by the Migration Factory: | ||
|
|
||
| | Credential | Storage Method | Used By | |
Contributor
There was a problem hiding this comment.
Any concern that the content here becomes stale?
| credentials are never stored in plaintext in Git. | ||
| 2. **AAP Credential Types** — Stores and injects credentials at runtime | ||
| via Ansible Automation Platform's built-in credential management. | ||
| 3. **Kubernetes Secrets** — Stores cluster-scoped credentials (API |
Contributor
There was a problem hiding this comment.
Not necessarily cluster scoped credentials. Can probably remove that distinction
|
|
||
| ### openshift_virtualization_migration_cac | ||
|
|
||
| Config-as-Code credential that stores Migration Factory configuration |
Contributor
There was a problem hiding this comment.
Suggested change
| Config-as-Code credential that stores Migration Factory configuration | |
| Config-as-Code credential that stores Ansible for OpenShift Virtualization Migration configuration |
| - `VMWARE_HOST`, `VMWARE_USER`, `VMWARE_PASSWORD` (env) | ||
| - Target name, host, insecure SSL flag, VDDK image details (extra vars) | ||
|
|
||
| ### Ovirt Migration Target |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Ovirt Migration Target | |
| ### oVirt Migration Target |
| rh_username: "{{ vault_rh_username }}" | ||
| rh_password: "{{ vault_rh_password }}" | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Add the values to the vaulted inventory.vault.yml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inventory.vault.yml.exampletemplate with all sensitive variables ready for Ansible Vault encryptiondocs/secure_credential_management.mddocumenting the full credential management architecture (Ansible Vault, AAP credential types, Kubernetes Secrets, environment variable injection).gitignoreto exclude*.vault.yml,vault-password*, and.vault-password*filesRelated
Test plan
inventory.vault.yml.examplecan be copied, edited, and encrypted withansible-vault encrypt--ask-vault-pass.gitignorepatterns prevent committing vault password and encrypted filesaap_seedrole🤖 Generated with Claude Code