feat(vm-storage-labeling): add storage volume labeling role#15
Open
stevefulme1 wants to merge 2 commits intoredhat-cop:mainfrom
Open
feat(vm-storage-labeling): add storage volume labeling role#15stevefulme1 wants to merge 2 commits intoredhat-cop:mainfrom
stevefulme1 wants to merge 2 commits intoredhat-cop:mainfrom
Conversation
…aming Add a new role and playbook to apply labels, annotations, and descriptive names to PersistentVolumeClaims and DataVolumes at the OCP level. Supports both named volume targeting and label selector-based bulk operations for managing storage across large VM fleets. Resolves: MFG-251 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@stevefulme1 Would this enhancement be better served within the |
Author
|
yes can we move the pr there? |
Contributor
Unfortunately, we cannot move the PR over. It would need to be recreated in the other repository |
sabre1041
reviewed
Apr 13, 2026
Contributor
sabre1041
left a comment
There was a problem hiding this comment.
Works well. Added one comment related to whether names/labels should be required
Let's complete the discussion in this repository and then transfer it to the ops repo
| fail_msg: "Required property 'namespace' in 'vm_storage_labeling_request' Variable Not Provided" | ||
| quiet: true | ||
|
|
||
| - name: Verify Names or Label Selectors Provided |
Contributor
There was a problem hiding this comment.
Is there a need to provide either labels or PVC names? What if we wanted to apply the same labels/annotations to all PVC's in a namespace?
Allow labeling all PVCs in a namespace when neither names nor label_selectors is provided. Addresses review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm_storage_labelingrole and playbook to apply labels, annotations, and descriptive names to PersistentVolumeClaims (PVCs) and DataVolumes at the OCP levelvm_mac_address,vm_hot_plug) for variable naming, validation, and k8s JSON patch operationsResolves
MFG-251 — Storage Volume Labeling and Naming
Usage Example
Test plan
yamllintpasses (confirmed locally — warnings only for line-length on playbook env lookups, matching existing patterns)ansible-lint --offlinepasses production profile (confirmed locally — 0 failures, 0 warnings)🤖 Generated with Claude Code