[Symfony61] Remove empty configure() method even with empty body#966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #965.
CommandConfigureToAttributeRectornow removes theconfigure()method when it has an empty body — and, importantly, no longer adds a useless empty#[AsCommand]attribute when there is nothing to move into it.final class EmptyConfigureBody extends \Symfony\Component\Console\Command\Command { - protected function configure(): void - { - } }Previously an already-empty
configure()would have gained a bogus#[AsCommand]with no arguments. The attribute is now only created/updated when there is at least one resolved argument (name,description,aliases,hidden).Non-empty
configure()bodies are untouched — the method is kept when real leftover calls remain (addOption(),addArgument(),setHelp(), …).