[Symfony44] Return 1 instead of (int) false in ConsoleExecuteReturnIntRector#963
Merged
Conversation
…tRector Casting false to int produces 0, which is the SUCCESS exit code. A command returning false means it failed, so map it to 1 (Command::FAILURE) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting
falseto int yields0— the SUCCESS exit code. But a command returningfalsemeans it failed, so the cast silently inverts the intent.This maps
return false;toreturn 1;(Command::FAILURE) instead.final class ReturnFalseCommand extends Command { - public function execute(InputInterface $input, OutputInterface $output) + public function execute(InputInterface $input, OutputInterface $output): int { - return false; + return 1; } }Before this change, the rule produced
return (int) false;— a command that reported success on failure.Note on
return true;The mirror case is still cast:
return true;becomesreturn (int) true;=1= FAILURE, when the intent is success (0). Left out of this PR to keep the scope tight — happy to follow up if wanted.