[Naming] Keep mass nouns ending in "data"/"info" untouched when singularizing - #8492
Merged
Merged
Conversation
…larizing Names like "ruleMetadata" ended in lowercase "data", which the Data/Info suffix guard (matching only capitalized "Data"/"Info" words) missed, so they fell through to the plain inflector and became "ruleMetadatum". Claude-Session: https://claude.ai/code/session_01GpZfp2wM56hSqNVvLPSY5T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RenameForeachValueVariableToMatchMethodCallReturnTypeRectorrenamed foreach variables like$ruleMetadata(overRuleMetadata[]) to$ruleMetadatum.Root cause is in
RectorNamingInflector::singularize(). TheData|Infosuffix guard only matches capitalizedData/Infocamel words (eguserData), soruleMetadata- which ends in lowercasedata, the tail of the single wordmetadata- fell through to the plain inflector and becameruleMetadatum.Now names ending in lowercase
data/info(mass nouns likemetadata) are kept untouched.Before:
After:
Existing behaviour is preserved:
userData->userDataruleMetadatas->ruleMetadataclassInfos->classInfoAdded a skip fixture covering a
RuleMetadata[]return type.https://claude.ai/code/session_01GpZfp2wM56hSqNVvLPSY5T