[BetterPhpDocParser] Resolve class references in Generic PHPDoc tag node containing "::"#7895
[BetterPhpDocParser] Resolve class references in Generic PHPDoc tag node containing "::"#7895ruudk wants to merge 1 commit intorectorphp:mainfrom
Conversation
|
I'd prefer generic solution that would not require configuration per project. |
|
How would you like to do that with a custom phpdoc like this? I believe this was done for performance reasons? |
|
I am on mobile, how about just remove the : This of course need to verify other decorator that doing similar logic on different docblock node to avoid overwritten. |
|
Yeah i think that would be fine too! |
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
bbaf88a to
a111b8f
Compare
ruudk
changed the title
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
a111b8f to
bb39d91
Compare
|
Updated the PR. This is much simpler. Thanks! |
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
bb39d91 to
017d054
Compare
|
@ruudk please update PR title to something like: since it apply only on Generic. |
ruudk
changed the title
|
Done, thanks! |
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
@TomasVotruba I think this ready for merge now 👍
| return null; | ||
| } | ||
|
|
||
| if (! in_array($node->name, ['@uses', '@used-by', '@see'], true)) { |
There was a problem hiding this comment.
does the class-name still fit, after you removed this line?
There was a problem hiding this comment.
the class changed here is named PhpDocTagGenericUsesDecorator .. I guess the name is related to if (! in_array($node->name, ['@uses', '@used-by', '@see'], true)) {
There was a problem hiding this comment.
@samsonasik what do you think? Could you do the change it you think it's worth it?
4 participants
No description provided.