docs(protocol): sweep 20 stale PROPOSED → SHIPPED state lines#199
Merged
NagyVikt merged 1 commit intoMay 20, 2026
Merged
Conversation
…t sweep) Audited docs/future/PROTOCOL.md against the actual repo + git history and flipped 20 stale `state: PROPOSED` lines to `state: SHIPPED` for items whose implementation has clearly landed on main. Each item's acceptance verification command runs green and the touched script/file already implements the proposal. Updates (section → slug → representative PR): - 1.4.1 Formal lifecycle states for every improvement entry → PR #171 (scripts/protocol/{protocol-state,check-states}.sh + state lines) - 7.4.1 --help/--version on stall-watcher.sh → PR #1 - 9.4.1 --help/--version on plan-watcher.sh → PR #46 - 10.4.1 --help/--version on review-queue.sh → PR #37 - 11.4.1 --help/--version on review-pane-scanner.sh → PR #41 - 12.4.1 --help/--version on auto-reviewer.sh → PR #99 - 17.4.1 --help/--version on show-fleet.sh → PR #139 - 18.4.1 --help/--version on token-meter.sh → PR #17 - 19.4.1 --help/--version on warm-pool.sh → PR #1 - 20.4.1 --help/--version on spawn-fleet.sh → PR #1 - 21.4.1 --help/--version on dispatch-plan.sh → PR #133 - 23.4.1 --help/--version on proactive-probe.sh → PR #1 - 24.4.1 --help/--version on claim-trigger.sh → PR #1 - 27.4.1 --help/--version on claude-supervisor.sh → PR #116 - 33.4.1 --help/--version on plan-tree-pin.sh → PR #1 - 36.4.1 --help/--version on supervisor.sh → PR #1 - 37.4.1 --help/--version on patch-codex-prompts.sh → PR #1 - 39.4.1 --help/--version on down.sh → PR #1 - 41.4.1 --help/--version on add-workers.sh → PR #1 - 42.4.1 --help/--version on codex-fleet-2.sh → PR #1 Diff is exactly 20 `- state: PROPOSED` → `- state: SHIPPED` line edits in docs/future/PROTOCOL.md; nothing else touched. Both governance checks still pass: bash scripts/protocol/check-states.sh # exit 0 bash scripts/protocol/protocol-state.sh --summary # SHIPPED: 0 → 20 PR refs live in this commit body / PR description rather than inline in the state line, because both check-states.sh and protocol-state.sh require the state token to be the bare enum value (e.g. `SHIPPED`); any suffix breaks both checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit pass over
docs/future/PROTOCOL.md: every#### X.4.Yimprovementcarrying
state: PROPOSEDwas checked against the actual repo + githistory. 20 items have clearly already shipped on
mainand are flippedto
SHIPPEDhere. Single-file, fully reversible change.State counts (before → after)
Updates (section → slug → representative PR)
--helpand--versionto stall-watcher.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto plan-watcher.sh → SHIPPED (PR feat(codex-fleet): plan-watcher supervisor + claude-runtime fallback #46)--helpand--versionto review-queue.sh → SHIPPED (PR feat(viz): add event-sourced producer for the Review approval queue #37)--helpand--versionto review-pane-scanner.sh → SHIPPED (PR feat(viz): close the Review approval-queue loop end-to-end #41)--helpand--versionto auto-reviewer.sh → SHIPPED (PR Add fleet auto-reviewer daemon #99)--helpand--versionto show-fleet.sh → SHIPPED (PR feat(codex-fleet): add show-fleet.sh operator entrypoint #139)--helpand--versionto token-meter.sh → SHIPPED (PR feat(codex-fleet): token-discipline worker + plan-meta + tiered panes #17)--helpand--versionto warm-pool.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto spawn-fleet.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto dispatch-plan.sh → SHIPPED (PR wip: capture pre-fleet-dispatch openspec scaffolding + script polish #133)--helpand--versionto proactive-probe.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto claim-trigger.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto claude-supervisor.sh → SHIPPED (PR feat(codex-fleet): tighten claude-supervisor classifier + replay harness #116)--helpand--versionto plan-tree-pin.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto supervisor.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto patch-codex-prompts.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto down.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto add-workers.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)--helpand--versionto codex-fleet-2.sh → SHIPPED (PR pkg: initial repo packaging — README, LICENSE, install.sh, skill, docs #1)Why bare
SHIPPED, notSHIPPED (PR #N)Both
scripts/protocol/check-states.shandscripts/protocol/protocol-state.shparse the state token verbatim:check-states.sh's awk validates against an exact enum(
{PROPOSED, ACCEPTED, SCHEDULED, IN-PROGRESS, SHIPPED, DEFERRED, REJECTED})and
protocol-state.shcounts via^- state: SHIPPED$. A(PR #N)suffix would break both. PR refs are captured here in the PR body and
in the commit message instead.
Audit method
For each
PROPOSEDitem I required:**References.**block exists in the repo, andarg parser handles
--help).I additionally cross-checked with
git log -S '--help' -- <path>to find arepresentative PR whose theme matches the proposal. For §1.4.1 the
referenced governance tooling (
scripts/protocol/{protocol-state,check-states}.sh)plus the state lines themselves were shipped under PR #171.
Acceptance evidence
Spot-check evidence (3 items)
Test plan
bash scripts/protocol/check-states.shpassesbash scripts/protocol/protocol-state.sh --summaryruns withouterror and reports SHIPPED count = 20
Risks / follow-ups
§16.4.1, §22.4.1, §25.4.1, §26.4.1, §28.4.1, §29.4.1, §30.4.1, §31.4.1,
§32.4.1, §34.4.1, §35.4.1, §38.4.1, §40.4.1 (--help/--version for other
scripts) were left as PROPOSED because the target script currently
lacks
--helponmainor is in flight on another agent branch. Theparallel agent A is wiring
--help/--versioninto a few of these(cap-probe, score-checkpoint, force-claim); that lane will sweep them
in a follow-up PR.
has a
--helpflag but a pre-arg-parse env precheck fatals before--helpis reached.*.4.2(structured logging) proposals stay PROPOSED — no scriptemits
level=structured lines yet.X.4.1proposals (43–54.4.1) stay PROPOSED — every cratehas < 50 lines of
//!docs.PROPOSED — acceptance criteria not yet met.