Add a cool download button to pre-release#2821
Open
Sarlay wants to merge 3 commits into
Open
Conversation
Collaborator
|
Great change! However, the download button does not match its surrounding content. See if you can make it similar to the join discord button, with slightly rounded corners, a bit more padding and left aligned. |
changed color, alignment and added a rounded border
Contributor
Author
|
Good ideas, tell me your thoughts about this one. |
| # CloudStream | ||
|
|
||
| **⚠️ Warning: By default, this app doesn't provide any video sources; you have to install extensions to add functionality to the app.** | ||
| <p align="left"><a href="https://github.com/recloudstream/cloudstream/releases/download/pre-release/app-prerelease-release.apk"><img src="https://i.imgur.com/OLumXoS.png" alt="Download Cloudstream Pre-Release" width=300/></a></p> |
Collaborator
There was a problem hiding this comment.
Looks good, just needs more padding to match the discord invite, and maybe the download icon can be changed to our internal download icon too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lots of fake websites online and the release tabs is hard to find sometimes