fix: fall back for invalid nested configurations - #6853
Open
raisulchowdhury wants to merge 5 commits into
Open
Conversation
Use the existing default-configuration fallback for automatically discovered nested SwiftLint configurations while preserving explicit configuration failures. Add a duplicate-key YAML regression test.\n\nAssisted-by: OpenAI Codex Signed-off-by: raisulchowdhury <34920788+raisulchowdhury@users.noreply.github.com>
Assisted-by: OpenAI Codex Signed-off-by: raisulchowdhury <34920788+raisulchowdhury@users.noreply.github.com>
Author
|
Status note: the focused regression and full MultipleConfigurationsTests suite pass locally. The external Buildkite swiftlint and bazel contexts are currently failing, but their provider does not expose logs through GitHub; the local environment also does not have the Assisted-by: OpenAI Codex. |
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6052
A prior implementation of this same narrow behavior was closed without merging in #6647; this version is adapted to the current test layout and verified against current main.
Validation
Assisted-by: OpenAI Codex. AI assistance was used for investigation, implementation, and test drafting; the submitted diff was reviewed and validated before publication.