Support Bazel 8 and 9#6780
Open
SimplyDanny wants to merge 2 commits into
Open
Conversation
Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
bazel-8
branch
2 times, most recently
from
1359045 to
5136aa5
Compare
There was a problem hiding this comment.
Pull request overview
Updates SwiftLint’s Bazel/Bzlmod configuration and CI to validate/build against Bazel 8 and 9 (in addition to 7), aligning repository defaults and presubmit coverage with the newer Bazel majors.
Changes:
- Add Bazel version matrices to GitHub Actions CI and BCR presubmit to run builds on Bazel 7/8/9.
- Update Bzlmod metadata/deps and default Bazel selection (
MODULE.bazel,.bazelversion). - Adjust Bazel-related tooling paths/flags (
Makefiledocs target,.bazelrccompression flag).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
MODULE.bazel |
Updates module metadata for Bazel compatibility and adjusts rules_swift dependency constraints. |
Makefile |
Updates the Bazel-built SourceKitten invocation used for Linux docs generation. |
.github/workflows/build.yml |
Runs Bazel CI on a 7/8/9 matrix. |
.bcr/presubmit.yml |
Expands BCR presubmit to a Bazel 7/8/9 matrix and updates the Linux platform/Swift toolchain download. |
.bazelversion |
Bumps the default Bazelisk-selected Bazel version to 9.x. |
.bazelrc |
Updates remote cache compression flag usage. |
Comment on lines
1
to
6
| module( | ||
| name = "swiftlint", | ||
| version = "0.64.1", | ||
| compatibility_level = 1, | ||
| bazel_compatibility = [">=7.0.0"], | ||
| repo_name = "SwiftLint", | ||
| ) |
| bazel_dep(name = "rules_cc", version = "0.2.19") | ||
| bazel_dep(name = "rules_shell", version = "0.8.0", repo_name = "build_bazel_rules_shell") | ||
| bazel_dep(name = "rules_swift", version = "3.6.1", max_compatibility_level = 3, repo_name = "build_bazel_rules_swift") | ||
| bazel_dep(name = "rules_swift", version = "3.6.1", repo_name = "build_bazel_rules_swift") |
Collaborator
Author
|
Could you take a look, @keith? Is it especially okay to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6630.