Honor parent_config / child_config in nested .swiftlint.yml files#6774
Open
JulianKahnert wants to merge 1 commit into
Open
Honor parent_config / child_config in nested .swiftlint.yml files#6774JulianKahnert wants to merge 1 commit into
JulianKahnert wants to merge 1 commit into
Conversation
Previously, nested .swiftlint.yml files discovered during linting were loaded with ignoreParentAndChildConfigs: true, silently dropping any parent_config / child_config keys they contained. Resolving them through the same FileGraph as the main config lets fleets of packages share a central rule set via parent_config in per-directory stubs (e.g. Tests/.swiftlint.yml referencing a common tests.yml) — the documented use case in realm#3540. The existing !fileGraph.includesFile(atPath:) guard still prevents re-merging a file already in the main config chain; FileGraph's per-graph cycle detection covers the nested case. Fixes realm#3540.
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #6773 (the original PR's head branch was lost when I deleted my fork — GitHub doesn't allow reopening in that case). Same commit, same changes.
Previously, nested .swiftlint.yml files discovered during linting were loaded with ignoreParentAndChildConfigs: true, silently dropping any parent_config / child_config keys they contained. Resolving them through the same FileGraph as the main config lets fleets of packages share a central rule set via parent_config in per-directory stubs (e.g. Tests/.swiftlint.yml referencing a common tests.yml) — the documented use case in #3540.
The existing !fileGraph.includesFile(atPath:) guard still prevents re-merging a file already in the main config chain; FileGraph's per-graph cycle detection covers the nested case.
Fixes #3540.