Skip to content

[3.x] Update test environment to avoid deprecated runner images and actions #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clue wants to merge 2 commits into
base: 3.x
Choose a base branch
from
+8 −7
Open

[3.x] Update test environment to avoid deprecated runner images and actions #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c55a59
Update test environment to avoid deprecated runner images and actions
clue Oct 3, 2026
3afb26a
Fix failing test on macOS 12+ when server closes TCP/IP connection
clue Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- 7.2
- 7.1
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
Expand All @@ -36,10 +36,10 @@ jobs:

PHPUnit-macOS:
name: PHPUnit (macOS)
runs-on: macos-14
runs-on: macos-26
continue-on-error: true
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: shivammathur/setup-php@v2
with:
php-version: 8.5
Expand Down
9 changes: 5 additions & 4 deletions tests/Query/TcpTransportExecutorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public function testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneCh
public function testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneChunkWhenServerClosesSocket()
{
if (PHP_OS === 'Darwin') {
// Skip on macOS because it exhibits what looks like a kernal race condition when sending excessive data to a socket that is about to shut down (EPROTOTYPE)
// Skip on macOS because it exhibits what looks like a kernel race condition when sending excessive data to a socket that is about to shut down (ECONNRESET, or EPROTOTYPE before macOS 12)
// Due to this race condition, this is somewhat flaky. Happens around 75% of the time, use `--repeat=100` to reproduce.
// fwrite(): Send of 4260000 bytes failed with errno=41 Protocol wrong type for socket
// @link http://erickt.github.io/blog/2014/11/19/adventures-in-debugging-a-potential-osx-kernel-bug/
Expand Down Expand Up @@ -406,9 +406,10 @@ public function testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocketWith
$writePending = $ref->getValue($executor);

// We expect an EPIPE (Broken pipe) on second write.
// However, macOS may report EPROTOTYPE (Protocol wrong type for socket) on first write due to kernel race condition.
// fwrite(): Send of 4260000 bytes failed with errno=41 Protocol wrong type for socket
// However, macOS may report ECONNRESET (Connection reset by peer) on first write due to kernel race condition.
// Before macOS 12, this was reported as EPROTOTYPE (Protocol wrong type for socket) instead.
// @link http://erickt.github.io/blog/2014/11/19/adventures-in-debugging-a-potential-osx-kernel-bug/
// @link https://github.com/apple-oss-distributions/xnu/blob/xnu-8019.41.5/bsd/netinet/tcp_usrreq.c#L1093
if ($writePending) {
$executor->handleWritable();
}
Expand All @@ -420,7 +421,7 @@ public function testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocketWith
$this->expectException(
\RuntimeException::class,
'Unable to send query to DNS server tcp://' . $address . ' (',
defined('SOCKET_EPIPE') ? (PHP_OS !== 'Darwin' || $writePending ? SOCKET_EPIPE : SOCKET_EPROTOTYPE) : null
defined('SOCKET_EPIPE') ? (PHP_OS !== 'Darwin' || $writePending ? SOCKET_EPIPE : SOCKET_ECONNRESET) : null
);
throw $exception;
}
Expand Down
Loading