Skip to content

Close out spec 004: implemented, #140 and #125 closed with credit - #206

Merged
adamjohnwright merged 1 commit into
mainfrom
docs/close-spec-004
Sep 10, 2026
Merged

Close out spec 004: implemented, #140 and #125 closed with credit#206
adamjohnwright merged 1 commit into
mainfrom
docs/close-spec-004

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

All 15 tasks complete. Both contributed PRs closed, each told specifically what of theirs was used.

@bleedblack1 (#140) — the instruction wording is in language_instruction.py nearly verbatim. It got the part that is easy to miss: nomenclature must survive untranslated, and SET, MAX and CAT are gene symbols as well as ordinary English words. They also picked the right profile.

They were also told where the 0 of 10 figure came from and that it was wrong — a dramatic number in a rejection deserves an explanation, and the honest figure is half the context, not all of it.

@bhavyakeerthi3 (#125) — the mechanism is theirs: a prompt variable rather than a concatenated query. They also kept the translate-to-English step while rewriting the rephrase prompt, which was the obvious thing to get wrong. And they were told plainly that closing it is not a decision about their hallucination grader, which belongs to #123 and is worth having.

Two wrong claims recorded, and the lesson

claim verdict
"BM25 retrieves close to nothing for French" false — it returns ten documents; seven of ten differ
"#140 leaves 0 of 10 documents" measured wrongly — that tested BM25 directly; through the pipeline it is 20 of 40

The second is the useful one. The first review checked whether each claim was true without checking whether the test measured the product — the same failure evaluator.py had four days earlier.

Worth watching: the French answer carried 2 R-HSA citations against English's 9. One sample, so not a finding — but if non-English answers systematically cite less, this feature closes a language gap while opening a quality one.

🤖 Generated with Claude Code

T012-T014. All 15 tasks complete.

Each contributor was told specifically what of theirs was used. #140's
instruction wording is in language_instruction.py nearly verbatim,
because it got the part that is easy to miss: nomenclature must survive
untranslated, and SET, MAX and CAT are gene symbols as well as English
words. #125's mechanism -- a prompt variable rather than a concatenated
query -- is the one #205 uses.

#140 was also told where the 0-of-10 figure came from and that it was
wrong, since a dramatic number in a rejection deserves an explanation.
#125 was told plainly that closing it is not a decision about its
hallucination grader, which belongs to #123 and is worth having.

Records both wrong claims and the lesson behind the second: the first
review checked whether each claim was true without checking whether the
test measured the product, which is the same failure evaluator.py had
four days earlier.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit 3eadf7e into main Sep 10, 2026
10 checks passed
@adamjohnwright
adamjohnwright deleted the docs/close-spec-004 branch September 10, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant