Refactored Integration Tests, for better stability. - #1198
Open
JakenVeina wants to merge 1 commit into
Open
JakenVeina wants to merge 1 commit into
JakenVeina wants to merge 1 commit into
Conversation
… as Integration tests, and thus not be parallelizable. Also cleaned up organization within SourceCacheFixture and WhenPropertyChangedFixture, while I was pulling tests out of them anyway.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored a variety of multi-threading stress tests to be classified as Integration tests, and thus not be parallelizable.
Also cleaned up organization within SourceCacheFixture and WhenPropertyChangedFixture, while I was pulling tests out of them anyway.
There's one test that still seems to be flaky, Cache.MergeManyChangeSetsFixture.ForListChangeSets.IntegrationTests.MultiThreadedStressTest(). This was the biggest offender for failed CI/CD runs before these changes, so there's probably some kind of deeper defect in the operator or in the tests, making it more unreliable than the others.