Repository navigation
[flow] Label dictionary keys in published Flow types - #528
Merged
Merged
Conversation
Flow's `experimental.require_dictionary_key_label` option requires every dictionary key to be labeled, as TypeScript does:
```js
type T = { [string]: number }; // error
type T = { [key: string]: number }; // ok
```
This labels the four unlabeled keys that end up in the package's published `.js.flow` files: `ReactDOMStyleProps`'s `style`, `Styles`, `MutableCustomProperties`, and the `style` prop of `merge`'s return type. Labels don't affect type checking.
## Test plan
`flow full-check` with Flow 0.338.0, using a copy of `.flowconfig` updated for 0.338 with the option turned on: the four `missing-dictionary-key-label` errors in `renderer.web.js`, `styles.js` and `merge.js` are gone, and no other errors change. `prettier --check` passes on the changed files.
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow's
experimental.require_dictionary_key_labeloption requires every dictionary key to be labeled, as TypeScript does:This labels the four unlabeled keys that end up in the package's published
.js.flowfiles:ReactDOMStyleProps'sstyle,Styles,MutableCustomProperties, and thestyleprop ofmerge's return type. Labels don't affect type checking.Test plan
flow full-checkwith Flow 0.338.0, using a copy of.flowconfigupdated for 0.338 with the option turned on: the fourmissing-dictionary-key-labelerrors inrenderer.web.js,styles.jsandmerge.jsare gone, and no other errors change.prettier --checkpasses on the changed files.