Repository navigation
test: add missing coverage for CellRenderMask.numCells() and equals() - #59460
saiyam-jain-dev wants to merge 1 commit into
Conversation
The CellRenderMask class exposes two public methods — numCells() and equals() — that had no test coverage at all. This commit adds: - numCells(): 3 tests covering empty mask, constructor size, and stability after addCells mutations - equals(): 6 tests covering identical masks, size mismatch, identical operations, differing regions, differing region counts, and reflexivity
|
Hi @saiyam-jain-dev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-tools
Bot
added
the
Shared with Meta
Summary
\CellRenderMask\ exposes two public methods —
umCells()\ and \equals()\ — that had zero test coverage. This adds 9 new test cases:
numCells() (3 tests)
equals() (6 tests)
All new tests follow the exact style of existing tests in the file.
Test Plan
yarn jest packages/virtualized-lists/Lists/tests/CellRenderMask-test.js
Changelog
[INTERNAL] [ADDED] - Add unit tests for CellRenderMask.numCells() and equals() methods which previously had no test coverage