Skip to content

fix: correct JSDoc typos in virtualized-lists - #59457

Open
saiyam-jain-dev wants to merge 1 commit into
react:mainfrom
saiyam-jain-dev:fix/virtualized-lists-jsdoc-typos
Open

saiyam-jain-dev wants to merge 1 commit into
react:mainfrom
saiyam-jain-dev:fix/virtualized-lists-jsdoc-typos

Conversation

@saiyam-jain-dev

@saiyam-jain-dev saiyam-jain-dev commented Oct 24, 2026 •

Copy link
Copy Markdown

Summary

  • \FillRateHelper.js: Fix typo \maximem\ -> \maximum\ in class-level JSDoc comment
  • \ViewabilityHelper.js: Fix incorrect prop reference in comment: \�iewAreaPercentThreshold\ -> \�iewAreaCoveragePercentThreshold. The referenced name does not exist anywhere in the codebase; the correct name is defined 3 lines above in the same \ViewabilityConfig\ type.

Both were verified by searching the entire repo — neither is an intentional alias.

Test Plan

Documentation-only change. No behavior change.

Changelog

[INTERNAL] [CHANGED] - Fix JSDoc typos in virtualized-lists: correct 'maximem' to 'maximum' in FillRateHelper and fix wrong prop name reference in ViewabilityHelper comment

- FillRateHelper.js: fix typo 'maximem' -> 'maximum' in class JSDoc
- ViewabilityHelper.js: fix incorrect prop name in comment
  'viewAreaPercentThreshold' -> 'viewAreaCoveragePercentThreshold'
  (the correct name as defined in ViewabilityConfig type above)
@meta-cla

meta-cla Bot commented Oct 24, 2026

Copy link
Copy Markdown

Hi @saiyam-jain-dev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 24, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants