Repository navigation
Reset Switch ripple tint when thumbColor is cleared, fix getOutlineWidth - #59451
Open
Abbondanzo wants to merge 2 commits into
Open
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
…oad the correct commit data. Differential Revision: D127266607
Summary: Two follow-ups to the Switch background-color fix (parent import). 1. Clearing thumbColor left the live ripple tinted with the old thumb color. setThumbColor stored null but skipped recoloring the existing ripple, so a Switch with backgroundColor + thumbColor kept the thumb tint on its pressed ripple after thumbColor was removed. Now a null thumbColor resets the ripple effect to the background's own content color, matching what the next setBackgroundColor would build. 2. BackgroundStyleApplicator.getOutlineWidth returned outlineOffset instead of outlineWidth, so readers got the offset value (or null when only a width was set). Changelog: [Android][Fixed] - Fix Switch keeping the thumbColor ripple tint after thumbColor is removed, and fix getOutlineWidth returning the outline offset Differential Revision: D127268268
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127268268. |
Visual regressionNo visual differences at ios: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Two follow-ups to the Switch background-color fix (parent import).
color. setThumbColor stored null but skipped recoloring the existing
ripple, so a Switch with backgroundColor + thumbColor kept the thumb
tint on its pressed ripple after thumbColor was removed. Now a null
thumbColor resets the ripple effect to the background's own content
color, matching what the next setBackgroundColor would build.
instead of outlineWidth, so readers got the offset value (or null when
only a width was set).
Changelog:
[Android][Fixed] - Fix Switch keeping the thumbColor ripple tint after thumbColor is removed, and fix getOutlineWidth returning the outline offset
Differential Revision: D127268268