Move renderer color parsing out of headers - #58521
Open
coado wants to merge 3 commits into
Open
Conversation
Summary: Rolls the umbrella-header + include-guard mechanism across the `react/renderer/graphics` module, classifying the target as public. - Adds `<React/Graphics.h>`, re-exporting the module's public interface headers. - Adds `<react/cxxstableapi/UmbrellaGuard.h>` to 24 root headers and all 18 platform headers. - Wires the umbrella header directory into the Buck, CMake, CocoaPods, Gradle, and iOS prebuild header configurations. `conversions.h` and `Geometry.h` are deliberately left unguarded. Both are deprecation shims whose only content is a `#warning` redirecting to their replacements; guarding them would bury that migration hint under a hard error, and their enforcement is inherited from the headers they forward to. `RCTPlatformColorUtils.h` is guarded but intentionally absent from the umbrella. It is an Objective-C++ header (`UIColor` / `RCTUIColor`, `#import <UIKit/UIKit.h>`), so including it would make the umbrella uncompilable from a plain C++ translation unit on Apple platforms. By contrast `configurePlatformColorCacheInvalidationHook.h` is plain C++ but exists only on Android, so it is included behind `#ifdef ANDROID`, following the pattern already used by `<React/View.h>`. `PlatformColorParser.h` and `fromRawValueShared.h` include `react/renderer/core/RawValue.h`, which was only reachable on Apple platforms because `react/renderer/core:rawValue` was restricted to `platforms = APPLE`. No source inside the graphics target included those headers off-Apple, so the breakage was latent and invisible; reaching them through the umbrella surfaces it. This change therefore widens `:rawValue` to all platforms and gives graphics an unconditional dependency on it. That target exists specifically to break the core/graphics dependency cycle, so no new cycle is introduced. Also adds `tests/UmbrellaCompileTest.cpp`, which does nothing but include the umbrella. No target compiled any umbrella header before this, so a non-compiling umbrella could previously only be discovered by downstream consumers. Changelog: [General][Added] - Add `<React/Graphics.h>` umbrella header for the graphics C++ module [Android][Fixed] - Fix `react/renderer/graphics` failing to compile `PlatformColorParser.h` on Android Differential Revision: D116779866
Summary: Declare direct CSS dependencies for renderer targets that consume CSS headers instead of relying on View or Graphics to expose them transitively. Cover Buck, CMake, CocoaPods, and SwiftPM without changing header visibility or runtime behavior. Changelog: [Internal] Differential Revision: D119489856
Summary: Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior. Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized. Changelog: [Internal] Differential Revision: D119500849
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119500849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move shared and platform-specific Graphics color-parsing implementations from exported headers into owned source files across generic C++, Android, Apple, and Windows targets. Preserve the existing public entry points and parsing behavior.
Update Buck source selection so default configurations link the generic C++ parser, and keep the React Native macOS and Windows mirrors synchronized.
Changelog: [Internal]
Differential Revision: D119500849