Move the SampleTurboModule main-queue annotation back to rn-tester - #58516
Open
alanjhughes wants to merge 1 commit into
Open
Move the SampleTurboModule main-queue annotation back to rn-tester#58516alanjhughes wants to merge 1 commit into
alanjhughes wants to merge 1 commit into
Conversation
Summary: #56723 moved `SampleTurboModule`'s `unstableRequiresMainQueueSetup` annotation from rn-tester's `codegenConfig` into react-native's. Codegen collects these annotations from every library and emits them into `RCTUnstableModulesRequiringMainQueueSetupProvider`, so every app now lists `SampleTurboModule`, and `RCTInstance` eagerly requests it at startup. The native class only ships with rn-tester (the `ReactCommon-Samples` pod), so every other app logs "Unable to find module for SampleTurboModule", which is a redbox in development. The annotation is keyed by module name and does not need to live next to the spec, so move it back to rn-tester, the one app that links the class. Running the generator with react-native alone now yields the six core modules; adding rn-tester's config yields the same list plus `SampleTurboModule`. Changelog: [iOS] [Fixed] - Stop apps from eagerly requesting the sample TurboModule that only rn-tester provides Test Plan: Ran `generateUnstableModulesRequiringMainQueueSetupProvider` against `packages/react-native` alone and against `packages/react-native` plus `packages/rn-tester`: rn-only: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager with-rn-tester: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager, SampleTurboModule Reproduced the redbox in Expo Go on 0.87.0, 0.87.1 and 0.88.0-rc.0.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Expo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#56723 moved
SampleTurboModule'sunstableRequiresMainQueueSetupannotation from rn-tester'scodegenConfiginto react-native's. Codegen collects these annotations from every library and emits them intoRCTUnstableModulesRequiringMainQueueSetupProvider, so every app now listsSampleTurboModule, andRCTInstanceeagerly requests it at startup. The native class only ships with rn-tester, so every other app logs "Unable to find module for SampleTurboModule", which is a redbox in development.The annotation is keyed by module name and does not need to live next to the spec, so move it back to rn-tester, the one app that links the class. Running the generator with react-native alone now yields the six core modules; adding rn-tester's config yields the same list plus
SampleTurboModule.Changelog:
[iOS] [Fixed] - Stop apps from requesting the sample TurboModule that only rn-tester provides
Test Plan:
Ran
generateUnstableModulesRequiringMainQueueSetupProvideragainstpackages/react-nativealone and againstpackages/react-nativepluspackages/rn-tester:rn-only: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager
with-rn-tester: AccessibilityManager, Appearance, AppState, DeviceInfo, PlatformConstants, StatusBarManager, SampleTurboModule
Reproduced the redbox in Expo Go on 0.87.0, 0.87.1 and 0.88.0-rc.0.