Skip to content

Fix Android URL keyboard input type #58505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix Android URL keyboard input type #58505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ve/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ public open class ReactTextInputManager public constructor() :
// the flags work out, the underlying field will end up a URI-type field.
flagsToSet = InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD
} else if (KEYBOARD_TYPE_URI.equals(keyboardType, ignoreCase = true)) {
flagsToSet = InputType.TYPE_TEXT_VARIATION_URI
flagsToSet = InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI
}

updateStagedInputTypeFlag(view, InputType.TYPE_MASK_CLASS, flagsToSet)
Expand Down
2 changes: 1 addition & 1 deletion ...actAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ class ReactTextInputPropertyTest {
fun testKeyboardTypeUrl() {
manager.updateProperties(view, buildStyles("keyboardType", "url"))
assertThat(view.inputType and generalKeyboardTypeFlags)
.isEqualTo(InputType.TYPE_TEXT_VARIATION_URI)
.isEqualTo(InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI)
}

@Test
Expand Down
Loading