fix: UB when upcasting yoga sentinel value - #57761
Closed
tjzel wants to merge 2 commits into
Closed
Conversation
Contributor
|
Upcasting from yoga::Node* to YGNodeRef is done across the yoga codebase, so it's weird to diverge here. Maybe just make |
Contributor
Author
|
@javache Done |
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D114202767. |
|
@fabriziocucci merged this pull request in 0dec9e2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing Undefined Behavior found with UB sanitizer ran against a React Native app.
Yoga always upcasts the node address, even if it is a sentinel value
0xbadc0ffee0ddf00d.UB sanitizer log
Changelog:
[INTERNAL] [FIXED] - UB when upcasting yoga sentinel value
Test Plan:
UBsan no longer complains.