refactor(iOS): persist bundle as local file on par with Android - #57751
Draft
tjzel wants to merge 3 commits into
Draft
refactor(iOS): persist bundle as local file on par with Android#57751tjzel wants to merge 3 commits into
tjzel wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, in development, the JS bundle is downloaded and saved as a file - this is done to avoid passing it through JNI, but iOS could use similar approach for uniform behavior.
This allows libraries to be able to obtain the bundle from the file without re-downloading it from Metro.
It would impact iOS boot slightly, but only in development, so it should be negligible.
Changelog:
[IOS] [CHANGED] - make iOS preserve dev bundle as a temp file on par with Android implementation
Test Plan:
rn-tester iOS dev works with this change