Skip to content

fix(iOS): reset accessibilityViewIsModal on view recycle to avoid trapping VoiceOver #57196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doracawl wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(iOS): reset accessibilityViewIsModal on view recycle to avoid trapping VoiceOver #57196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,13 @@ - (void)prepareForRecycle
_removeClippedSubviews = NO;
_reactSubviews = [NSMutableArray new];
_layoutMetrics = {};

// Reset accessibilityViewIsModal so it does not leak across recycled views.
// updateProps only writes this property when (oldProps != newProps); after a
// view is recycled _props resets to the default (NO), so a recycled view that
// is reused without the prop keeps the stale YES and traps VoiceOver / UI
// automation against a now-unrelated subtree (empty accessibility tree).
self.accessibilityElement.accessibilityViewIsModal = NO;
}

- (void)setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(NSSet<NSString *> *_Nullable)props
Expand Down
Loading