Skip to content

Deprecate legacy DefaultReactActivityDelegate constructors (#56906)#56906

Closed
javache wants to merge 1 commit into
react:mainfrom
javache:export-D105816717
Closed

Deprecate legacy DefaultReactActivityDelegate constructors (#56906)#56906
javache wants to merge 1 commit into
react:mainfrom
javache:export-D105816717

Conversation

@javache

@javache javache commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary:

These flags were already ignored.

Changelog: [Android][Deprecated] DefaultReactActivityDelegate's constructor taking new arch flags are deprecated

Reviewed By: cortinico

Differential Revision: D105816717

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
@meta-codesync

meta-codesync Bot commented May 20, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105816717.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot changed the title Deprecate legacy DefaultReactActivityDelegate constructors Deprecate legacy DefaultReactActivityDelegate constructors (#56906) May 20, 2026
@javache javache force-pushed the export-D105816717 branch from a9c2e1f to f74217a Compare May 20, 2026 11:09
javache added a commit to javache/react-native that referenced this pull request May 20, 2026
Summary:

These flags were already ignored.

Changelog: [Android][Deprecated] DefaultReactActivityDelegate's constructor taking new arch flags are deprecated

Reviewed By: cortinico

Differential Revision: D105816717
Summary:

These flags were already ignored.

Changelog: [Android][Deprecated] DefaultReactActivityDelegate's constructor taking new arch flags are deprecated

Reviewed By: cortinico

Differential Revision: D105816717
@javache javache force-pushed the export-D105816717 branch from f74217a to 7f195b0 Compare May 20, 2026 11:34
@meta-codesync meta-codesync Bot closed this in 935f8e5 May 20, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @javache in 935f8e5

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 20, 2026
@meta-codesync

meta-codesync Bot commented May 20, 2026

Copy link
Copy Markdown

This pull request has been merged in 935f8e5.

@javache javache deleted the export-D105816717 branch May 20, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants