Migrate NativeSampleTurboModule to codegen integration - RFC (#56723)#56723
Closed
christophpurrer wants to merge 1 commit into
Closed
Migrate NativeSampleTurboModule to codegen integration - RFC (#56723)#56723christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104323543. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
f41a976 to
37b7f10
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
37b7f10 to
04dfb4e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
04dfb4e to
22d3f32
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 8, 2026
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
22d3f32 to
b9e1698
Compare
…6723) Summary: Replace hand-written spec files for `NativeSampleTurboModule` with proper codegen integration by removing exclusion rules and configuring the module in `package.json`. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec. Changelog: [Internal] Differential Revision: D104323543
christophpurrer
force-pushed
the
export-D104323543
branch
from
b9e1698 to
33ae88b
Compare
|
This pull request has been merged in 734f5c1. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 734f5c1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace hand-written spec files for
NativeSampleTurboModulewith proper codegen integration by removing exclusion rules and configuring the module inpackage.json. This eliminates ~1600 lines of manual boilerplate (Java, C++, Objective-C) across Android, iOS, and macOS platforms, allowing the codegen system to generate these files automatically from the JavaScript spec.Changelog: [Internal]
Differential Revision: D104323543