Skip to content

Bump flow-{api-translator,eslint,parser} to 0.333.0, declare @babel/parser - #1998

Open
robhogan wants to merge 1 commit into
mainfrom
pr1997
Open

robhogan wants to merge 1 commit into
mainfrom
pr1997

Conversation

@robhogan

@robhogan robhogan commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

This bumps the Flow tooling packages from 0.331.0 to 0.333.0, matching flow-bin. From 0.332.0, flow-api-translator translates declare module.exports to TypeScript's export = (facebook/flow#9491), which #1996 uses to generate definitions for CommonJS modules.

It also declares @babel/parser as a root dev dependency. The API snapshot script has imported it since #1988, but it only resolved because other packages hoist it. The range matches theirs, so it doesn't change the lockfile.

Changelog: Internal

Test plan:
Generated .d.ts (gitignored) and all 14 API snapshots are unchanged on the new versions.

…l/parser`

Bumps the Flow tooling packages from 0.331.0 to 0.333.0, matching `flow-bin`. 0.332.0 onwards translates `declare module.exports` to TypeScript's `export =` (facebook/flow#9491), which the next PR uses to generate definitions for CommonJS modules. On its own, this changes no generated output.

Also declares `@babel/parser` as a root dev dependency. `scripts/generateApiSnapshots.js` has imported it since #1988, but it only resolved because other packages hoist it. The range matches theirs, so the lockfile doesn't change for it.

Changelog: Internal

Test plan:
Generated `.d.ts` and all 14 API snapshots are unchanged, and `tsc`, Flow and lint are clean.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2026
@robhogan
robhogan added this pull request to stack #1999 September 29, 2026 15:13
@robhogan

robhogan commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

@vzaidman (or @SamChou19815?) - I've split this out from #1977 because it's the bit that'll need importing and landing in Phabricator (maybe with a yarn.lock sync) - I don't want to cause more diff train chaos ;)

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 29, 2026
@vzaidman

Copy link
Copy Markdown
Contributor

I'll import it soon. I need to land one more small diff regarding flow internally before.

@meta-codesync

meta-codesync Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D122383746.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. needs-meta-import Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants