Align OSS Flow config with lib.dom.d.ts - #1989
Merged
Merged
Conversation
Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
robhogan
approved these changes
Sep 28, 2026
Contributor
Author
|
@SamChou19815 let me know if there's some problem landing it and we can revert it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1965: internal and OSS Flow disagreed on DOM builtins, so suppressions removed there were unused in OSS but needed once the DOM lib is provided by Flow itself.
.flowconfig:builtin_lib=flowlib-with-lib-dom-d-tsflow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.jsflow-typed/environment/node.js: useglobalThis.Blob; drop an unused suppressionConsole(index-test.js,resolver-test.js,logToConsole.js) and drop ones now unusedHMRClient-test.js: mockWebSocketviajest.spyOn(global, "WebSocket", "get")instead of writing the readonly globalTest plan:
flow checkshows no new errors and no new unused suppressions in metro filesyarn jest packages/metro-runtime/src/modules/__tests__/HMRClient-test.jspasses