Propagate Bundler transformer initialization errors - #1854
Conversation
|
Hi @Boulea7! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fixes #1808.
Preserve and propagate the original Transformer construction error after reporting
transformer_load_failed. Attach an immediate observer to the initialization promise so a caller can await the same rejected promise later without an unhandled rejection.Changelog: [Fix] Propagate Transformer initialization errors from Bundler
Test plan
yarn jest packages/metro/src/__tests__/Bundler-test.js --runInBandfailed on236ea72f1:ready()did not reject andtransformFile()surfaced the follow-on undefined-transformer error.yarn jest packages/metro/src/__tests__/Bundler-test.js --runInBand(3 tests passed).yarn jest --runInBand(141 suites, 2533 tests passed).yarn typecheckyarn lintyarn build