Skip to content

fix: replace vulnerable image-size with image-size-next (CVE-2025-71329/71330) #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lcf2212dev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −12
Open

fix: replace vulnerable image-size with image-size-next (CVE-2025-71329/71330) #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/metro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"flow-enums-runtime": "^0.0.6",
"graceful-fs": "^4.2.4",
"flow-parser": "0.325.0",
"image-size": "^1.0.2",
"image-size-next": "2.1.0",
"invariant": "^2.2.4",
"jest-worker": "^29.7.0",
"jsc-safe-url": "^0.2.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/metro/src/Assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import type {AssetPath} from './node-haste/lib/AssetPaths';

import {normalizePathSeparatorsToPosix} from './lib/pathUtils';
import * as AssetPaths from './node-haste/lib/AssetPaths';
// $FlowFixMe[untyped-import] image-size
import getImageSize from 'image-size';
// $FlowFixMe[untyped-import] image-size-next (maintained drop-in for image-size)
import getImageSize from 'image-size-next';
import crypto from 'node:crypto';
import fs from 'node:fs';
import path from 'node:path';
Expand Down Expand Up @@ -51,7 +51,7 @@ export type AssetDataFiltered = {
...
};

// Test extension against all types supported by image-size module.
// Test extension against all types supported by image-size / image-size-next module.
// If it's not one of these, we won't treat it as an image.
export function isAssetTypeAnImage(type: string): boolean {
return (
Expand Down
4 changes: 2 additions & 2 deletions packages/metro/src/__tests__/Assets-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
'use strict';

jest.mock('node:fs', () => new (require('metro-memory-fs'))());
jest.mock('image-size');
jest.mock('image-size-next');

jest.useRealTimers();

Expand All @@ -24,7 +24,7 @@ const fs = jest.requireMock('node:fs');
const mockImageWidth = 300;
const mockImageHeight = 200;

require('image-size').mockReturnValue({
require('image-size-next').mockReturnValue({
width: mockImageWidth,
height: mockImageHeight,
});
Expand Down
11 changes: 5 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3517,12 +3517,11 @@ ignore@^7.0.5:
resolved "https://registry.yarnpkg.com/ignore/-/ignore-7.0.5.tgz#4cb5f6cd7d4c7ab0365738c7aea888baa6d7efd9"
integrity sha512-Hs59xBNfUIunMFgWAbGX5cq6893IbWg4KnrjbYwX3tx0ztorVgTDA6B2sxf8ejHJ4wz8BqGUMYlnzNBer5NvGg==

image-size@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/image-size/-/image-size-1.0.2.tgz#d778b6d0ab75b2737c1556dd631652eb963bc486"
integrity sha512-xfOoWjceHntRb3qFCrh5ZFORYH8XCdYpASltMhZ/Q0KZiOwjdE/Yl2QCiWdwD+lygV5bMCvauzgu5PxBX/Yerg==
dependencies:
queue "6.0.2"
image-size-next@2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/image-size-next/-/image-size-next-2.1.0.tgz#f0c2d5ea995f6beb974b17c02265d924647a360f"
integrity sha512-OUXyc22p+zA9CmiJbuYygTcoHbmZ9tFnJ0NX8LcgfewtrKJnfM+zYwsfrNdoKqz9WsSPTR++2yz+Fqz7Rzvvjg==


import-fresh@^3.2.1:
version "3.3.0"
Expand Down