Collect dependencies from createRequire-bound require calls#1734
Open
jeferson-sb wants to merge 1 commit into
Open
Collect dependencies from createRequire-bound require calls#1734jeferson-sb wants to merge 1 commit into
jeferson-sb wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
3 tasks
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
|
Hi @jeferson-sb This is Node JS specific which Metro doesn't directly support, but I see no issue recognising these dependencies for framework use as long as the heuristic is sufficiently tight. So this should recognise only functions created by calling a factory where that factory is bound to the Ideally, it recognises those even if they're not called If we can tighten that up a bit (with tests against false positives) I'd be happy to accept this. Thanks for working on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESM packages use
const require = createRequire(import.meta.url)to emulate CJS require. Previously,collectDependenciesskipped these calls becauserequirehad a local binding. This change detects when the binding comes from a factory callUpstream issue from Expo: 46129
Test plan
Regular unit tests and the project from the issue: https://github.com/floklein/expo-server-sdk-packagejson-bug