Skip to content

fix: show subtitles on submenus #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
juliusmarminge wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: show subtitles on submenus #1219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84e2fb9
fix: show subtitles on submenus
juliusmarminge Aug 10, 2026
d1fb163
fix: keep inline menu sections stock
juliusmarminge Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ios/Shared/RCTMenuItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,19 @@ class RCTMenuAction {
subMenuActions.append(subaction.createUIMenuElement(handler))
}
var menu: UIMenu;
// Stable identifiers let updateVisibleMenu match submenu nodes in
// place, so a refresh while the menu is presented keeps the user's
// current submenu level instead of popping back to the root.
// Inline sections don't navigate, so they stay stock.
let menuIdentifier = identifier.map { UIMenu.Identifier(rawValue: $0.rawValue) }
if self.displayInline {
menu = UIMenu(title: title, image: image, options: .displayInline, children: subMenuActions)
} else {
menu = UIMenu(title: title, image: image, children: subMenuActions)
menu = UIMenu(title: title, image: image, identifier: menuIdentifier, children: subMenuActions)
}

if #available(iOS 15.0, *) {
menu.subtitle = subtitle
}

if #available(iOS 16.0, *) {
Expand Down