Skip to content

breaking: Remove /open-stack-frame from cli-server-api - #2875

Draft
huntie wants to merge 1 commit into
mainfrom
pr2875
Draft

huntie wants to merge 1 commit into
mainfrom
pr2875

Conversation

@huntie

@huntie huntie commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

React Native core serves /open-stack-frame from @react-native/dev-middleware, with validation, a watch folder restriction and a throttle this copy lacks. Remove the CLI's copy so core's handler answers the route.

Test Plan

yarn build
yarn lint
yarn test packages/cli-server-api

✅ Clean; the two lint warnings are in files this change does not touch.

With this cli-server-api linked into RNTester running react/react-native#59316, on an iPhone 18 Pro simulator:

  • ✅ curl -X POST /open-stack-frame for a file in the repo answered 200 with core's OK body, so core's handler served the route.
  • ✅ Tapping a LogBox stack frame opened the editor once, at the frame's file and line.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant