Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React Native core serves
/open-stack-framefrom@react-native/dev-middleware, with validation, a watch folder restriction and a throttle this copy lacks. Remove the CLI's copy so core's handler answers the route.cli-tools'launchEditorexport andbody-parserstay;openURLMiddlewarestill uses the latter.Test Plan
✅ Clean; the two lint warnings are in files this change does not touch.
With this
cli-server-apilinked into RNTester running react/react-native#59316, on an iPhone 18 Pro simulator:curl -X POST /open-stack-framefor a file in the repo answered200with core'sOKbody, so core's handler served the route.Checklist
react-nativecheckout (instructions).