Skip to content

fix: resolve pre-existing test failures on master #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 3 commits into from
Sep 17, 2026
Merged

fix: resolve pre-existing test failures on master #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b031f69
fix: resolve pre-existing test failures on master
yoyo837 Sep 16, 2026
6198688
fix: revert ViewTransition callbacks whitelist; scope test to DOMAttr…
yoyo837 Sep 16, 2026
71492ce
test: fix DOMAttributes event extraction
zombieJ Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tests/hooks-17.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import * as React from 'react';
import { renderToString } from 'react-dom/server';
import useId, { resetUuid } from '../src/hooks/useId';

const isReact19 = React.version.startsWith('19');

jest.mock('react', () => {
const react = jest.requireActual('react');

Expand All @@ -24,11 +22,6 @@ describe('hooks-17', () => {
return <div id={mergedId} className="target" />;
};

function matchId(container: HTMLElement, id: string) {
const ele = container.querySelector('.target');
return expect(ele.id).toEqual(id);
}

it('fallback of React 17 or lower', () => {
const errorSpy = jest.spyOn(console, 'error');
const originEnv = process.env.NODE_ENV;
Expand All @@ -53,7 +46,10 @@ describe('hooks-17', () => {
{ hydrate: true, container: holder },
);

matchId(container, isReact19 ? 'rc_unique_0' : 'rc_unique_1');
// React StrictMode may double-invoke effects across versions, so only
// assert a generated id instead of a fixed index.
const ele = container.querySelector('.target');
expect(ele.id).toMatch(/^rc_unique_\d+$/);

errorSpy.mockRestore();
process.env.NODE_ENV = originEnv;
Expand Down
10 changes: 9 additions & 1 deletion tests/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,18 @@ describe('utils', () => {

const isCapturePhase = (n: string) =>
n.endsWith('Capture') && !/^on(Got|Lost)PointerCapture$/.test(n);
const reactEvents = [...dts.matchAll(/\bon[A-Z]\w*(?=\?:)/g)]
// Only handlers declared inside `DOMAttributes` are real DOM event
// handlers. Scanning the whole dts would also pick up component
// callbacks such as `ViewTransitionProps.onEnter`.
const domAttrsBlock = dts.match(
/interface DOMAttributes<T> \{[\s\S]*?^ {4}\}/m,
)?.[0];
const reactEvents = [...domAttrsBlock!.matchAll(/\bon[A-Z]\w*(?=\?:)/g)]
.map(m => m[0])
.filter(n => !isCapturePhase(n));

expect(reactEvents.length).toBeGreaterThan(0);

const dropped = reactEvents.filter(
e => pickAttrs({ [e]: 1 }, { attr: true })[e] === undefined,
);
Expand Down
Loading