Allowed for multiple time formats in the header time input#239
Open
hsource wants to merge 1 commit intoreact-component:masterfrom
Open
Allowed for multiple time formats in the header time input#239hsource wants to merge 1 commit intoreact-component:masterfrom
hsource wants to merge 1 commit intoreact-component:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While testing with users, we found that users were often entering times like 11am or 12:30 and confused when the time picker wouldn't change to save those times.
Fix
Add a new prop called
validFormats. This allows us to parse more formats than the default of 12:00 PM.Testing
Tested in our own app that uses this (https://wanderlog.com)