add event to onChange and onAmPmChange#189
add event to onChange and onAmPmChange#189Stas-Buzunko wants to merge 2 commits intoreact-component:masterfrom
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/time-picker/khumntal6 |
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 6 6
Lines 381 381
Branches 99 99
=======================================
Hits 350 350
Misses 31 31
Continue to review full report at Codecov.
|
|
Please why as this not been merged and to master for release. This feature is needed |
|
Will this PR be merged to master soon? |
when time-picker is used with react-bootstrap Modals / Popovers / Overlays and you click on time it makes Modals / Popovers / Overlays close because this event happens outside container
the only way to control this by passing event so that it can't be prevented / stopped.
Some people in issues said they need to modify event for some reasons
#173
#92
feel free to modify pr as i've done it quickly for my own needs.