Add mulit format support to TimePicker#133
Open
NathanBP wants to merge 11 commits intoreact-component:masterfrom
Open
Add mulit format support to TimePicker#133NathanBP wants to merge 11 commits intoreact-component:masterfrom
NathanBP wants to merge 11 commits intoreact-component:masterfrom
Conversation
Author
|
Test which is failing is already failing in master branch. Once this is fixed this pull request will pass the required checks. |
Author
|
great |
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
========================================
+ Coverage 89.5% 90% +0.49%
========================================
Files 7 8 +1
Lines 381 390 +9
Branches 93 93
========================================
+ Hits 341 351 +10
+ Misses 40 39 -1
Continue to review full report at Codecov.
|
|
Could this implemented feature be taken into use? It would be helpful at least in some countries around the world. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows format prop to allow an array of formats. The control then uses the array of formats when parsing a date from the input. The first value of the array determines the displayed format.
An example use case is that a user may want to enter a time as hmm but display as h:mm a.