fix: use logical suffix offset for rtl overflow#60
fix: use logical suffix offset for rtl overflow#60zombieJ merged 2 commits intoreact-component:masterfrom
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 44 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough更新了 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the Overflow component to use the logical CSS property insetInlineStart instead of left for positioning. A review comment suggests explicitly appending the 'px' unit to this property to maintain compatibility with React versions prior to 18, which do not automatically add units to logical CSS properties.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Overflow.tsx`:
- Around line 318-323: 测试断言需要跟实现同步:在 Overflow.tsx 中当 suffixFixedStart !== null 且
shouldResponsive 时,后缀样式改为使用逻辑属性 insetInlineStart(由 suffixStyle 设置),请在
tests/responsive.spec.tsx 中把显式断言 left: 80 更新为断言逻辑属性(例如断言
element.style.insetInlineStart === '80px' 或使用匹配器同时接受 left 或
insetInlineStart),以兼容 RTL 修复并避免 CI 失败。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
ci 挂了 |
Summary
leftoffset withinset-inline-startCloses ant-design/ant-design#57680
Summary by CodeRabbit
Style