Skip to content

feat: MD3 styles for shared tab accessory markup - #51

Closed
phiamo wants to merge 3 commits into
rdlabo-dev:mainfrom
phiamo:feat/tab-accessory
Closed

phiamo wants to merge 3 commits into
rdlabo-dev:mainfrom
phiamo:feat/tab-accessory

Conversation

@phiamo

@phiamo phiamo commented Oct 1, 2026 •

Copy link
Copy Markdown

Summary

Related to rdlabo-dev/ionic-theme-ios27#248

Test plan

  • Open the demo Library tab and confirm the Material mini-player capsule above ion-tab-bar
  • Play/pause does not open the sheet; toolbar click does
  • Swipe-up follows the finger then clicks the original toolbar
  • .md3-disabled on the toolbar keeps standard Ionic styling
  • class="ios-theme-tab-accessory" still gets the MD3 capsule (alias)

Style ion-toolbar.ios-theme-tab-accessory as the Material capsule so the same template works with @rdlabo/ionic-theme-ios27. Swipe-up stays in the ios27 package.

Co-authored-by: Cursor <cursoragent@cursor.com>
phiamo and others added 2 commits October 1, 2026 11:33
Canonical opt-in is tab-accessory so Material does not depend on an ios-theme class. enableTabAccessory lives in this package with no ios27 import; ios-theme-tab-accessory remains a CSS/JS alias.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@phiamo

phiamo commented Oct 16, 2026

Copy link
Copy Markdown
Author

Following the Native UI Shell extension direction on rdlabo-dev/ionic-theme-ios27#276 / #277, we’ll keep the mini-player capsule and swipe-up in the app instead of a shared tab-accessory theme contract.

The MD3 styles and enableTabAccessory() from this PR are app-owned now. I’ll close this; nothing here needs to stay in the theme.

@phiamo phiamo closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant