Repository navigation
fix(native-ui): stabilize sheet modal dismissal handoff - #329
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
Flaky testschromium › native-ui.spec.ts › Duo sheet modal sends one native presentation clock instead of moving frames |
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-329/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.0.3-beta.pr329.shae7b859fee773 @rdlabo/capacitor-native-ui@2.0.3-beta.pr329.shae7b859fee773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a sheet modal on iPhone Duo could flash the covered page twice: the moving modal kept refreshing native projection, and Ionic's paused sheet-backdrop gesture animation could become visible again during dismissal.
Retire native modal controls once at
ionModalWillDismiss, leave the closing animation on the Web, and restore the underlying page projection afterionModalDidDismiss. Geometry refreshes after retirement no longer publish repeated native snapshots, and modal ownership changes use an immediate handoff.For native vertical-bar sheets, release only Ionic's recognized dormant backdrop gesture effect after dismissal is accepted. Running/custom animations, ordinary Web sheets, and gesture-driven dismissal are left alone. This compatibility handling lives entirely in the library; no consuming-app or Ionic source changes are required.
Validation:
Additional Duo rail fixes (
0bf0d50c):UIView.performWithoutAnimation. Normal animated rail updates retain their existing behavior.clientLeft/clientTopround border widths to whole CSS pixels; the coordinate conversion now subtracts the computed border widths instead. This avoids the measured subpixel offset without changing button shapes.Additional validation:
npm run cap),npx cap update, and iOS simulator build passed.