Repository navigation
fix: retain popover anchors when triggers become disabled - #327
Merged
Merged
Conversation
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-327/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Duo Vertical Bars button can become disabled in its click handler to prevent duplicate actions. The popover anchor checks treated that state as an invalid anchor and fell back to Web rendering after a valid tap.
Keep an accepted, projected button as a popover anchor when it becomes disabled, both in the Web bridge and the native presenter. Existing disabled-action checks still reject additional clicks; missing anchors and unsupported popovers retain their existing fallback behavior.
Validation:
CI also exposed a race in the existing tab-width handoff test: toolbar artwork could finish after the tab-bar acknowledgement. Wait for both toolbar groups to be projected before asserting that update counts stop increasing. The tab payload was unchanged during the extra toolbar update. Reproduced with 4x CPU slowdown; the corrected test passed five consecutive runs in that condition.